Sign upLogin

eugene-matvejev/battleship-game-api

View on GitHub
Star

Showing 153 of 153 total issues

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'getLiveCells'.
Open

        $this->assertCount(48, BattlefieldModel::getLiveCells($battlefield));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'flagWaterAroundShipOnA1AlreadyDead'.
Open

        $battlefield = MockFactory::getBattlefieldMock();
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\FoundationBundle\Model\PlayerModel' in method 'createOnRequestAIControlledOnExistingPlayer'.
Open

        $this->assertTrue(PlayerModel::isAIControlled($player));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/PlayerModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'addBattlefield'.
Open

        $game = MockFactory::getGameMock();
Severity: Minor
Found in tests/phpunit/GameBundle/Response/GameInitiationResponseTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processPathsComplete'.
Open

        $battlefield = MockFactory::getBattlefieldMock();
Severity: Minor
Found in tests/phpunit/GameBundle/Service/AI/AIStrategyProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processPlayerTurnOnBattlefieldOnNotWin'.
Open

        $this->assertFalse($this->processPlayerTurnOnBattlefield($battlefield, MockFactory::getPlayerMock('')));
Severity: Minor
Found in tests/phpunit/GameBundle/Service/GameSystem/GameProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processTurnToWin'.
Open

        $game->getBattlefields()[1]->setPlayer(MockFactory::getAIPlayerMock(''));
Severity: Minor
Found in tests/phpunit/GameBundle/Service/GameSystem/GameProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'hasUnfinishedShips'.
Open

        $this->assertFalse(BattlefieldModel::hasUnfinishedShips($battlefield));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'generate'.
Open

        $battlefield = BattlefieldModel::generate(7, $shipCells);
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\CellModel' in method 'switchPhaseWithAdditionalFlag'.
Open

                return CellModel::switchPhase($cell, CellModel::FLAG_SKIP);
Severity: Minor
Found in tests/phpunit/GameBundle/Model/CellModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'setCellsOnExternalCall'.
Open

        $response = new GameTurnResponse(MockFactory::getGameMock(), []);
Severity: Minor
Found in tests/phpunit/GameBundle/Response/GameTurnResponseTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'pickCellToAttackExpectedCell'.
Open

        $cell = $this->pickCellToAttack([MockFactory::getCellMock('A1'), MockFactory::getCellMock('A2')]);
Severity: Minor
Found in tests/phpunit/GameBundle/Service/AI/AIServiceTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'AdjacentCellsProvider'.
Open

                MockFactory::getBattlefieldMock(),
Severity: Minor
Found in tests/phpunit/GameBundle/Service/CoordinateSystem/PathProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processPlayerTurnOnBattlefieldToWin'.
Open

            ->setPlayer(MockFactory::getAIPlayerMock(''));
Severity: Minor
Found in tests/phpunit/GameBundle/Service/GameSystem/GameProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'EM\GameBundle\Model\CellModel' in method 'flagWaterAroundShip'.
Open

                CellModel::switchPhase($waterCell, CellModel::FLAG_SKIP);
Severity: Minor
Found in src/GameBundle/Model/BattlefieldModel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'processPlayerTurnOnBattlefield'.
Open

            return !BattlefieldModel::hasUnfinishedShips($battlefield);
Severity: Minor
Found in src/GameBundle/Service/GameSystem/GameProcessor.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'removeFlag'.
Open

        $cell = MockFactory::getCellMock('A1');
Severity: Minor
Found in tests/phpunit/FoundationBundle/ORM/AbstractFlaggedEntityTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'AdjacentCellsProvider'.
Open

                MockFactory::getBattlefieldMock(),
Severity: Minor
Found in tests/phpunit/GameBundle/Service/CoordinateSystem/PathProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processTurnToWin'.
Open

        $game = MockFactory::getGameMock();
Severity: Minor
Found in tests/phpunit/GameBundle/Service/GameSystem/GameProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'buildGame'.
Open

        $battlefield = BattlefieldModel::generate($request->getSize(), $request->getCoordinates());
Severity: Minor
Found in src/GameBundle/Service/GameSystem/GameBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language