Sign upLogin

evalphobia/go-jp-text-ripper

View on GitHub
Star

Showing 13 of 13 total issues

Method RipProcessor.Do has 73 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *RipProcessor) Do() error {
    defer r.Close()
    c := r.Config
    logger := c.Logger
    if c.UseRankingForStopWord() {
Severity: Minor
Found in ripper/processor_rip.go - About 1 hr to fix

    Method RankProcessor.getRank has 53 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r *RankProcessor) getRank() (RankResult, error) {
    defer r.r.Close()
    c := r.Config
    logger := c.Logger
    idx := r.columnIndex
    Severity: Minor
    Found in ripper/processer_rank.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (r *RankProcessor) DoWithProgress() error {
    r.ShowProgress()

    conf := r.Config
    logger := conf.Logger
      Severity: Minor
      Found in ripper/processer_rank.go and 1 other location - About 55 mins to fix
      ripper/processor_rip.go on lines 153..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (r *RipProcessor) DoWithProgress() error {
    r.ShowProgress()

    conf := r.Config
    logger := conf.Logger
      Severity: Minor
      Found in ripper/processor_rip.go and 1 other location - About 55 mins to fix
      ripper/processer_rank.go on lines 108..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method RipProcessor.Do has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r *RipProcessor) Do() error {
    defer r.Close()
    c := r.Config
    logger := c.Logger
    if c.UseRankingForStopWord() {
      Severity: Minor
      Found in ripper/processor_rip.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method RipProcessor.Do has 5 return statements (exceeds 4 allowed).
      Open

      func (r *RipProcessor) Do() error {
    defer r.Close()
    c := r.Config
    logger := c.Logger
    if c.UseRankingForStopWord() {
      Severity: Major
      Found in ripper/processor_rip.go - About 35 mins to fix

        Function getCharacterRatioFromText has 5 return statements (exceeds 4 allowed).
        Open

        func getCharacterRatioFromText(data map[string]string, target string) string {
    targetStr, ok := data[target]
    if !ok {
        return ""
    }
        Severity: Major
        Found in postfilter/ratio_postfilter.go - About 35 mins to fix

          Function DoRank has 5 return statements (exceeds 4 allowed).
          Open

          func DoRank(conf RankConfig) error {
    if err := conf.Init(); err != nil {
        return err
    }
    if err := conf.Validate(); err != nil {
          Severity: Major
          Found in ripper/processer_rank.go - About 35 mins to fix

            Method RankProcessor.GetRank has 5 return statements (exceeds 4 allowed).
            Open

            func (r *RankProcessor) GetRank() (RankResult, error) {
    c := r.Config

    rank, err := r.getRank()
    if err != nil {
            Severity: Major
            Found in ripper/processer_rank.go - About 35 mins to fix

              Method Tokenizer.isValidWord has 5 return statements (exceeds 4 allowed).
              Open

              func (t *Tokenizer) isValidWord(pos, surface string) bool {
    if _, ok := t.wordPosMap[pos]; !ok {
        return false
    }
    if len(surface) < t.minLetterSize {
              Severity: Major
              Found in tokenizer/tokenizer.go - About 35 mins to fix

                Function DoRip has 5 return statements (exceeds 4 allowed).
                Open

                func DoRip(conf RipConfig) error {
    if err := conf.Init(); err != nil {
        return err
    }
    if err := conf.Validate(); err != nil {
                Severity: Major
                Found in ripper/processor_rip.go - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  var KanaNumberLikeCountPlugin = &ripper.Plugin{
    Title: "kana_number_count",
    Fn: func(text *ripper.TextData) string {
        count := strings.Count(jpNumberReplacer.Replace(strings.ToLowerSpecial(kanaConv, text.GetNormalized())), jpSymbol)
        return strconv.Itoa(count)
                  Severity: Minor
                  Found in plugin/kana_plugin.go and 1 other location - About 35 mins to fix
                  plugin/kana_plugin.go on lines 75..81

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  var KanaAlphabetLikeCountPlugin = &ripper.Plugin{
    Title: "kana_alphabet_count",
    Fn: func(text *ripper.TextData) string {
        count := strings.Count(jpAlphabetReplacer.Replace(strings.ToLowerSpecial(kanaConv, text.GetNormalized())), jpSymbol)
        return strconv.Itoa(count)
                  Severity: Minor
                  Found in plugin/kana_plugin.go and 1 other location - About 35 mins to fix
                  plugin/kana_plugin.go on lines 66..72

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language