Sign upLogin

evandcoleman/node-appletv

View on GitHub
Star

Showing 38 of 38 total issues

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    try {
      let device = await openDevice(credentials, logger);
      let data = await device.requestArtwork();
      if (options.output) {
        await promisify(writeFile)(options.output, data);
Severity: Major
Found in src/bin/index.ts and 5 other locations - About 40 mins to fix
src/bin/index.ts on lines 32..48
src/bin/index.ts on lines 61..70
src/bin/index.ts on lines 108..118
src/bin/index.ts on lines 135..150
src/bin/index.ts on lines 162..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    try {
      let device = await openDevice(credentials, logger);
      device.on('message', (message: Message) => {
        logger.info(JSON.stringify(message.toObject(), null, 2));
      });
Severity: Major
Found in src/bin/index.ts and 5 other locations - About 40 mins to fix
src/bin/index.ts on lines 32..48
src/bin/index.ts on lines 61..70
src/bin/index.ts on lines 83..96
src/bin/index.ts on lines 108..118
src/bin/index.ts on lines 135..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    try {
      let device = await openDevice(credentials, logger);
      let message = await device
        .requestPlaybackQueue({
          location: options.location || 0,
Severity: Major
Found in src/bin/index.ts and 5 other locations - About 40 mins to fix
src/bin/index.ts on lines 32..48
src/bin/index.ts on lines 61..70
src/bin/index.ts on lines 83..96
src/bin/index.ts on lines 108..118
src/bin/index.ts on lines 162..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function HKDF has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function HKDF(hashAlg: string, salt: Buffer, ikm: Buffer, info: Buffer, size: number): Buffer {
Severity: Minor
Found in src/lib/util/encryption.ts - About 35 mins to fix

    Function verifyAndDecrypt has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function verifyAndDecrypt(cipherText: Buffer, mac: Buffer, AAD: Buffer, nonce: Buffer, key: Buffer): Buffer {
    Severity: Minor
    Found in src/lib/util/encryption.ts - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

            return AppleTV.Key.Home;
      Severity: Major
      Found in src/lib/appletv.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return AppleTV.Key.Previous;
        Severity: Major
        Found in src/lib/appletv.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return AppleTV.Key.Next;
          Severity: Major
          Found in src/lib/appletv.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return AppleTV.Key.Select;
            Severity: Major
            Found in src/lib/appletv.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return AppleTV.Key.Wake;
              Severity: Major
              Found in src/lib/appletv.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return AppleTV.Key.VolumeDown;
                Severity: Major
                Found in src/lib/appletv.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return AppleTV.Key.Menu;
                  Severity: Major
                  Found in src/lib/appletv.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return AppleTV.Key.VolumeUp;
                    Severity: Major
                    Found in src/lib/appletv.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return AppleTV.Key.Play;
                      Severity: Major
                      Found in src/lib/appletv.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return AppleTV.Key.Pause;
                        Severity: Major
                        Found in src/lib/appletv.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return AppleTV.Key.Suspend;
                          Severity: Major
                          Found in src/lib/appletv.ts - About 30 mins to fix

                            Function onNewListener has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                              private onNewListener(event: string, listener: any) {
    let that = this;
    if (this.queuePollTimer == null && (event == 'nowPlaying' || event == 'supportedCommands')) {
      this.queuePollTimer = setInterval(() => {
        if (that.connection.isOpen) {
                            Severity: Minor
                            Found in src/lib/appletv.ts - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function initiatePair has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                              async initiatePair(): Promise<(pin: string) => Promise<AppleTV>> {
    let that = this;
    let tlvData = tlv.encode(
      tlv.Tag.PairingMethod, 0x00,
      tlv.Tag.Sequence, 0x01,
                            Severity: Minor
                            Found in src/lib/pairing.ts - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language