Sign upLogin

evandcoleman/node-appletv

View on GitHub
Star
src/lib/pairing.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function completePairing has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private async completePairing(pin: string): Promise<AppleTV> {
    await this.sendThirdSequence(pin);
    let message = await this.device.waitForSequence(0x04);
    let pairingData = message.payload.pairingData;
    this.deviceProof = tlv.decode(pairingData)[tlv.Tag.Proof];
Severity: Minor
Found in src/lib/pairing.ts - About 1 hr to fix

    Function initiatePair has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async initiatePair(): Promise<(pin: string) => Promise<AppleTV>> {
    let that = this;
    let tlvData = tlv.encode(
      tlv.Tag.PairingMethod, 0x00,
      tlv.Tag.Sequence, 0x01,
    Severity: Minor
    Found in src/lib/pairing.ts - About 1 hr to fix

      Function initiatePair has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        async initiatePair(): Promise<(pin: string) => Promise<AppleTV>> {
    let that = this;
    let tlvData = tlv.encode(
      tlv.Tag.PairingMethod, 0x00,
      tlv.Tag.Sequence, 0x01,
      Severity: Minor
      Found in src/lib/pairing.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status