Sign upLogin

eveseat/api

View on GitHub
Star
src/Http/Controllers/Api/v2/CharacterController.php

Summary

Maintainability
D
2 days
Test Coverage

The class CharacterController has a coupling between objects value of 24. Consider to reduce the number of dependencies under 13.
Open

class CharacterController extends ApiController
{
    use Filterable;

    /**
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Avoid using static access to class '\Seat\Api\Http\Resources\ContactResource' in method 'getContacts'.
Open

        return ContactResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\CorporationHistoryResource' in method 'getCorporationHistory'.
Open

        return CorporationHistoryResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\NotificationResource' in method 'getNotifications'.
Open

        return NotificationResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getAssets'.
Open

        return Resource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\JumpcloneResource' in method 'getJumpClones'.
Open

        return JumpcloneResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getSkillQueue'.
Open

        return Resource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\MailResource' in method 'getMail'.
Open

        return MailResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\IndustryResource' in method 'getIndustry'.
Open

        return IndustryResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getWalletTransactions'.
Open

        return Resource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getMarketOrders'.
Open

        return Resource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\ContractResource' in method 'getContracts'.
Open

        return ContractResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getWalletJournal'.
Open

        return Resource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getSkills'.
Open

        return Resource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getContracts(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 1 other location - About 2 hrs to fix
src/Http/Controllers/Api/v2/CorporationController.php on lines 235..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getWalletTransactions(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 878..891
src/Http/Controllers/Api/v2/CorporationController.php on lines 301..314
src/Http/Controllers/Api/v2/CorporationController.php on lines 600..613
src/Http/Controllers/Api/v2/CorporationController.php on lines 666..679

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getWalletJournal(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 944..957
src/Http/Controllers/Api/v2/CorporationController.php on lines 301..314
src/Http/Controllers/Api/v2/CorporationController.php on lines 600..613
src/Http/Controllers/Api/v2/CorporationController.php on lines 666..679

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getMarketOrders(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getAssets(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getSkills(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getSkillQueue(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getNotifications(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getIndustry(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getContacts(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getCorporationHistory(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getJumpClones(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status