Sign upLogin

eveseat/api

View on GitHub
Star

Showing 137 of 137 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getContracts(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 1 other location - About 2 hrs to fix
src/Http/Controllers/Api/v2/CorporationController.php on lines 235..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getContracts(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 1 other location - About 2 hrs to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 242..257

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getWalletJournal(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 944..957
src/Http/Controllers/Api/v2/CorporationController.php on lines 301..314
src/Http/Controllers/Api/v2/CorporationController.php on lines 600..613
src/Http/Controllers/Api/v2/CorporationController.php on lines 666..679

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getWalletTransactions(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 878..891
src/Http/Controllers/Api/v2/CharacterController.php on lines 944..957
src/Http/Controllers/Api/v2/CorporationController.php on lines 301..314
src/Http/Controllers/Api/v2/CorporationController.php on lines 600..613

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getWalletTransactions(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 878..891
src/Http/Controllers/Api/v2/CorporationController.php on lines 301..314
src/Http/Controllers/Api/v2/CorporationController.php on lines 600..613
src/Http/Controllers/Api/v2/CorporationController.php on lines 666..679

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getIndustry(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 878..891
src/Http/Controllers/Api/v2/CharacterController.php on lines 944..957
src/Http/Controllers/Api/v2/CorporationController.php on lines 600..613
src/Http/Controllers/Api/v2/CorporationController.php on lines 666..679

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getWalletJournal(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 878..891
src/Http/Controllers/Api/v2/CharacterController.php on lines 944..957
src/Http/Controllers/Api/v2/CorporationController.php on lines 301..314
src/Http/Controllers/Api/v2/CorporationController.php on lines 666..679

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/fr/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/de/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/ko/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/zh-CN/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/ja/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/af/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/ru/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/ro/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/en/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/resources/lang/en/seat.php and 8 other locations - About 1 hr to fix
src/resources/lang/af/seat.php on lines 1..47
src/resources/lang/de/seat.php on lines 1..47
src/resources/lang/fr/seat.php on lines 1..47
src/resources/lang/ja/seat.php on lines 1..47
src/resources/lang/ko/seat.php on lines 1..47
src/resources/lang/ro/seat.php on lines 1..47
src/resources/lang/ru/seat.php on lines 1..47
src/resources/lang/zh-CN/seat.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getSkillQueue(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getAssets(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getContacts(int $alliance_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/AllianceController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getAssets(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language