Sign upLogin

eveseat/api

View on GitHub
Star
src/Http/Middleware/ApiToken.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Seat\Api\Models\ApiTokenLog' in method 'log_activity'.
Open

            ApiTokenLog::create([
                'api_token_id' => $token_id,
                'action'       => $action,
                'method'       => $request->method(),
                'request_path' => $request->path(),
Severity: Minor
Found in src/Http/Middleware/ApiToken.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $tk. Configured minimum length is 3.
Open

        $tk = ApiTokenModel::where('token', $request->header('X-Token'))
Severity: Minor
Found in src/Http/Middleware/ApiToken.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The method valid_token_ip is not named in camelCase.
Open

    public function valid_token_ip(Request $request)
    {
        $tk = ApiTokenModel::where('token', $request->header('X-Token'))
                        ->first();
Severity: Minor
Found in src/Http/Middleware/ApiToken.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method log_activity is not named in camelCase.
Open

    public function log_activity(Request $request, $action)
    {

        if (config('api.config.log_requests')) {
Severity: Minor
Found in src/Http/Middleware/ApiToken.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status