Sign upLogin

eveseat/eveapi

View on GitHub
Star

Showing 440 of 440 total issues

Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
Open

            if (! File::exists($storage))
Severity: Minor
Found in src/Commands/Eve/Update/Sde.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Market\CharacterOrder' in method 'handle'.
Open

                $model = CharacterOrder::firstOrNew([
                    'character_id' => $this->getCharacterId(),
                    'order_id' => $order->order_id,
                ]);
Severity: Minor
Found in src/Jobs/Market/Character/History.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$new_value'.
Open

    public function bypassReadOnly(bool $new_value = true)
Severity: Minor
Found in src/Traits/IsReadOnly.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Seat\Eveapi\Models\Market\CorporationOrder' in method 'handle'.
Open

                $model = CorporationOrder::firstOrNew([
                    'corporation_id' => $this->getCorporationId(),
                    'order_id' => $order->order_id,
                ]);
Severity: Minor
Found in src/Jobs/Market/Corporation/History.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Redis' in method 'clear_redis_cache'.
Open

            Redis::flushall();
Severity: Minor
Found in src/Commands/Seat/Cache/Clear.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Composer\InstalledVersions' in method 'downloadStaticFiles'.
Open

                $version = InstalledVersions::getPrettyVersion('eveseat/eveapi');
Severity: Minor
Found in src/database/seeders/Sde/SdeSeeder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationInfo' in method 'handle'.
Open

                $corporation = CorporationInfo::firstOrNew(
                    ['corporation_id' => $token->character->affiliation->corporation_id],
                    ['name' => "Unknown Corporation : {$token->character->affiliation->corporation_id}"]
                );
Severity: Minor
Found in src/Commands/Esi/Update/Killmails.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'check_storage'.
Open

        if (! File::isWritable(storage_path('sde')))
Severity: Minor
Found in src/Commands/Seat/Admin/Diagnose.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
Open

        if (File::isWritable(storage_path())) {
Severity: Minor
Found in src/database/seeders/Sde/SdeSeeder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Tests\Eveapi\Database\Factories\CharacterAffiliationFactory' in method 'newFactory'.
Open

        return CharacterAffiliationFactory::new();
Severity: Minor
Found in src/Models/Character/CharacterAffiliation.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Bucket' in method 'seedBuckets'.
Open

        $buckets_count = Bucket::count();
Severity: Minor
Found in src/Traits/BucketManager.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$key'.
Open

            $records = $chunk->map(function ($system, $key) {
Severity: Minor
Found in src/Jobs/Sovereignty/Map.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationTitle' in method 'handle'.
Open

            $corporation_title = CorporationTitle::firstOrCreate([
                'corporation_id' => $this->token->character->affiliation->corporation_id,
                'title_id' => $title->title_id,
            ], [
                'name' => $title->name,
Severity: Minor
Found in src/Jobs/Character/Titles.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractDetail' in method 'handle'.
Open

                $model = ContractDetail::firstOrNew([
                    'contract_id' => $contract->contract_id,
                ]);
Severity: Minor
Found in src/Jobs/Contracts/Character/Contracts.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractBid' in method 'handle'.
Open

                            ContractBid::firstOrCreate([
                                'bid_id' => $bid->bid_id,
                            ], [
                                'contract_id' => $this->contract_id,
                                'bidder_id' => $bid->bidder_id,
Severity: Minor
Found in src/Jobs/Contracts/Corporation/Bids.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationBlueprint' in method 'handle'.
Open

                    $model = CorporationBlueprint::firstOrNew([
                        'item_id' => $blueprint->item_id,
                    ]);
Severity: Minor
Found in src/Jobs/Corporation/Blueprints.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationStarbase' in method 'handle'.
Open

                $model = CorporationStarbase::firstOrNew([
                    'corporation_id' => $this->getCorporationId(),
                    'starbase_id' => $starbase->starbase_id,
                ]);
Severity: Minor
Found in src/Jobs/Corporation/Starbases.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Fittings\CharacterFittingItem' in method 'handle'.
Open

                    CharacterFittingItem::firstOrCreate([
                        'fitting_id' => $fitting->fitting_id,
                        'type_id' => $item->type_id,
                        'flag' => $item->flag,
                    ], [
Severity: Minor
Found in src/Jobs/Fittings/Character/Fittings.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'handle'.
Open

                $row = CharacterMining::select(DB::raw('SUM(quantity) as quantity'))
Severity: Minor
Found in src/Jobs/Industry/Character/Mining.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Killmails\KillmailAttacker' in method 'handle'.
Open

            $model = KillmailAttacker::firstOrNew([
                'killmail_id' => $this->killmail_id,
                'character_id' => property_exists($attacker, 'character_id') ?
                    $attacker->character_id : null,
                'corporation_id' => property_exists($attacker, 'corporation_id') ?
Severity: Minor
Found in src/Jobs/Killmails/Detail.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language