Sign upLogin

eveseat/notifications

View on GitHub
Star

Showing 405 of 405 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/database/migrations/2015_12_02_153458_create_notifications_table.php and 1 other location - About 1 hr to fix
src/database/migrations/2016_11_22_051322_create_integrations_table.php on lines 1..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/*
 * This file is part of SeAT
 *
Severity: Major
Found in src/database/migrations/2016_11_22_051322_create_integrations_table.php and 1 other location - About 1 hr to fix
src/database/migrations/2015_12_02_153458_create_notifications_table.php on lines 1..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function postAddAffiliation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function postAddAffiliation(GroupAffiliation $request)
    {

        $group = NotificationGroup::findOrFail($request->input('id'));
Severity: Minor
Found in src/Http/Controllers/GroupsController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toSlack has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->content('A Structure has been destroyed!')
            ->from('SeAT Structure Monitor')
Severity: Minor
Found in src/Notifications/Structures/Slack/StructureDestroyed.php - About 1 hr to fix

    Method toSlack has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->content('A structure has been transferred!')
            ->from('SeAT Structure Monitor')
    Severity: Minor
    Found in src/Notifications/Structures/Slack/OwnershipTransferred.php - About 1 hr to fix

      Avoid using short method names like CreateGroupAlertsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::create('group_alerts', function (Blueprint $table) {
      Severity: Minor
      Found in src/database/migrations/2016_11_23_211809_create_group_alerts_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateNotificationHistoriesTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::create('notification_histories', function (Blueprint $table) {
      Severity: Minor
      Found in src/database/migrations/2016_11_25_070843_create_notification_histories_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateNotificationsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::create('notifications', function (Blueprint $table) {
      Severity: Minor
      Found in src/database/migrations/2015_12_02_153458_create_notifications_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateIntegrationNotificationGroupsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::create('integration_notification_group', function (Blueprint $table) {
      Severity: Minor
      Found in src/database/migrations/2016_11_22_052836_create_integration_notification_groups_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like UpdateL53NotificationsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::dropIfExists('notifications');
      Severity: Minor
      Found in src/database/migrations/2016_11_22_063519_update_l53_notifications_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateNotificationGroupsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::create('notification_groups', function (Blueprint $table) {
      Severity: Minor
      Found in src/database/migrations/2016_11_22_052359_create_notification_groups_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like DropTypeFromNotificationGroups::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table('notification_groups', function (Blueprint $table) {
            $table->dropColumn('type');
        });
      Severity: Minor
      Found in src/database/migrations/2019_02_09_110731_drop_type_from_notification_groups.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateIntegrationsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::create('integrations', function (Blueprint $table) {
      Severity: Minor
      Found in src/database/migrations/2016_11_22_051322_create_integrations_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateGroupAffiliationsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        Schema::create('group_affiliations', function (Blueprint $table) {
      Severity: Minor
      Found in src/database/migrations/2016_11_23_211804_create_group_affiliations_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like DropDeprecatedEveType::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {

        NotificationGroup::with('alerts')->where('type', 'eve')->delete();
    }
      Severity: Minor
      Found in src/database/migrations/2018_07_13_215714_drop_deprecated_eve_type.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Method toSlack has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->content('A structure is running low in fuel!')
            ->from('SeAT Structure Monitor')
      Severity: Minor
      Found in src/Notifications/Structures/Slack/StructureFuelAlert.php - About 1 hr to fix

        Method toSlack has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->from('SeAT - New Application')
            ->content($this->notification->text['applicationText'])
        Severity: Minor
        Found in src/Notifications/Corporations/Slack/CorpAppNewMsg.php - About 1 hr to fix

          Method ajax has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function ajax()
    {
        return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->addColumn('alerts', function ($row) {
          Severity: Minor
          Found in src/Http/DataTables/NotificationGroupDataTable.php - About 1 hr to fix

            Method toSlack has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function toSlack($notifiable)
    {
        $message = (new SlackMessage())
            ->from('SeAT War Observer')
            ->content('A new War has been declared !')
            Severity: Minor
            Found in src/Notifications/Wars/Slack/AllWarDeclaredMsg.php - About 1 hr to fix

              Method toSlack has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->content('A new corporation bill has been issued!')
            ->from('SeAT Corporation Accountant')
              Severity: Minor
              Found in src/Notifications/Corporations/Slack/CorpAllBillMsg.php - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language