Sign upLogin

eveseat/services

View on GitHub
Star

Showing 106 of 106 total issues

Function parse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function parse(string $report)
    {
        $lines = explode($this->line_delimiter, $report);

        foreach ($lines as $line)
Severity: Minor
Found in src/ReportParser/ReportParser.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long variable names like $extension_class_instance. Keep variable name length under 20.
Open

            $extension_class_instance = new $extension_class;
Severity: Minor
Found in src/Models/ExtensibleModel.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $extension_class_instance. Keep variable name length under 20.
Open

            $extension_class_instance = new $extension_class;
Severity: Minor
Found in src/Models/ExtensibleModel.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Function boot has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function boot()
    {

        // If we are in debug mode, listen to database events
        // and log queries to the log file.
Severity: Minor
Found in src/ServicesServiceProvider.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPackageLatestVersion has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getPackageLatestVersion(string $vendor, string $package): string
    {
        // construct the packagist uri to its API
        $packagist_url = sprintf('https://packagist.org/packages/%s/%s.json',
            $vendor, $package);
Severity: Minor
Found in src/Traits/VersionsManagementTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate()
    {
        if ($this->isEmpty())
            throw new EmptyReportException();
Severity: Minor
Found in src/ReportParser/Parsers/MoonReport.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method evemail_threads has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function evemail_threads($message)
    {

        // Explode the messages based on the delimiter added
        // by the EVE Online Client.
Severity: Minor
Found in src/Helpers/helpers.php - About 1 hr to fix

    Method __construct has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(string $type, string $variation, ?int $id, int $size, array $attr = [], bool $lazy = true)
    {
        // Validate the arguments
        if (! in_array($type, $this->known_types))
            throw new EveImageException($type . ' is not a valid image type.');
    Severity: Minor
    Found in src/Image/Eve.php - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if ($id > 90000000 && $id < 98000000)
            return 'characters';

        elseif (($id > 98000000 && $id < 99000000) || ($id > 1000000 && $id < 2000000))
            return 'corporations';
      Severity: Critical
      Found in src/Image/Eve.php - About 1 hr to fix

        Avoid using short method names like ConvertValueFromStringToText::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::table('global_settings', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2016_11_29_195441_convert_value_from_string_to_text.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like ConvertChineseLanguageValue::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {
        UserSetting::where([
            ['name', 'language'],
            ['value', '"cn"'],
        Severity: Minor
        Found in src/database/migrations/2021_01_02_120325_convert_chinese_language_value.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like CreateGlobalSettingsTable::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::create('global_settings', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2015_11_28_071315_create_global_settings_table.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like AlterHistoricalPricesColumns::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::table('historical_prices', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2018_10_05_064533_alter_historical_prices_columns.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like CreateNotesTable::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::create('notes', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2016_11_19_065120_create_notes_table.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like CreateEveNotificationTypesTable::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::create('eve_notification_types', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2015_10_30_140512_create_eve_notification_types_table.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like DropHistoricalPrices::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::dropIfExists('historical_prices');
    }
        Severity: Minor
        Found in src/database/migrations/2020_05_10_101541_drop_historical_prices.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like MoveSettingsToGroups::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::table('user_settings', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2018_05_18_185619_move_settings_to_groups.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like CreateHistoricalPricesTable::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::create('historical_prices', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2018_09_12_181511_create_historical_prices_table.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like CreateUserSettingsTable::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::create('user_settings', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2015_11_28_053529_create_user_settings_table.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like CreateSchedulesTable::up(). The configured minimum method name length is 3.
        Open

            public function up()
    {

        Schema::create('schedules', function (Blueprint $table) {
        Severity: Minor
        Found in src/database/migrations/2015_12_01_201414_create_schedules_table.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Severity
        Category
        Status
        Source
        Language