Sign upLogin

eveseat/services

View on GitHub
Star

Showing 106 of 106 total issues

The method getPackageLatestVersion() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
Open

    protected function getPackageLatestVersion(string $vendor, string $package): string
    {
        // construct the packagist uri to its API
        $packagist_url = sprintf('https://packagist.org/packages/%s/%s.json',
            $vendor, $package);
Severity: Minor
Found in src/Traits/VersionsManagementTrait.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method detect_type is not named in camelCase.
Open

    public function detect_type($id)
    {
        if ($id === null)
            return 'unknown';
Severity: Minor
Found in src/Image/Eve.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method add_migrations is not named in camelCase.
Open

    private function add_migrations()
    {
        $this->loadMigrationsFrom(__DIR__ . '/database/migrations/');
    }
Severity: Minor
Found in src/ServicesServiceProvider.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_affected_id is not named in camelCase.
Open

    public static function get_affected_id($for_id)
    {

        // Without auth, return what we have.
        if (! auth()->check())
Severity: Minor
Found in src/Settings/Settings.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_key_prefix is not named in camelCase.
Open

    public static function get_key_prefix($name, $for_id = null)
    {

        // Ensure we have a prefix to work with.
        if (is_null(static::$prefix))
Severity: Minor
Found in src/Settings/Settings.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method add_event_listeners is not named in camelCase.
Open

    private function add_event_listeners(): void
    {
        Event::listen(MigrationsEnded::class, RunDeferredMigrations::class);
    }
Severity: Minor
Found in src/ServicesServiceProvider.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language