Avoid using static access to class '\Illuminate\Support\Facades\Cache' in method 'get'. Open
return Cache::rememberForever(self::get_key_prefix($name,
self::get_affected_id($for_id)), function () use ($name, $for_id) {
// Init a new MODEL
$value = (new static::$model);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Illuminate\Support\Facades\Cache' in method 'set'. Open
Cache::forever(self::get_key_prefix($name, self::get_affected_id($for_id)), $value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid variables with short names like $db. Configured minimum length is 3. Open
$db = (new static::$model);- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The method get_affected_id is not named in camelCase. Open
public static function get_affected_id($for_id)
{
// Without auth, return what we have.
if (! auth()->check())- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method get_key_prefix is not named in camelCase. Open
public static function get_key_prefix($name, $for_id = null)
{
// Ensure we have a prefix to work with.
if (is_null(static::$prefix))- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}