Sign upLogin

eveseat/web

View on GitHub
Star

Showing 479 of 479 total issues

The method apply uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $query->where('expires_on', '<', carbon());
                    }
Severity: Minor
Found in src/Http/DataTables/Scopes/Filters/TokenStatusScope.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$squad'.
Open

    public function reject(Squad $squad, int $id)
Severity: Minor
Found in src/Http/Controllers/Squads/ApplicationsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$request'.
Open

    public function getSearchCharacterSkillsData(Request $request)
Severity: Minor
Found in src/Http/Controllers/Support/SearchController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$request'.
Open

    public function getSearchCorporationsData(Request $request)
Severity: Minor
Found in src/Http/Controllers/Support/SearchController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$validator'.
Open

    public function validate($attribute, $value, $parameters, $validator)
Severity: Minor
Found in src/Http/Validation/Custom/Cron.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$character'.
Open

    public function getFitting(CharacterInfo $character, int $item_id)
Severity: Minor
Found in src/Http/Controllers/Character/AssetsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$character'.
Open

    public function getContainer(CharacterInfo $character, int $item_id)
Severity: Minor
Found in src/Http/Controllers/Character/AssetsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method update() has an NPath complexity of 870. The configured NPath complexity threshold is 200.
Open

    public function update(Request $request, Role $role)
    {
        $request->validate([
            'title' => 'string|required',
            'description' => 'string|nullable',
Severity: Minor
Found in src/Http/Controllers/Configuration/AccessController.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method update() has 116 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function update(Request $request, Role $role)
    {
        $request->validate([
            'title' => 'string|required',
            'description' => 'string|nullable',
Severity: Minor
Found in src/Http/Controllers/Configuration/AccessController.php by phpmd

Avoid unused parameters such as '$corporation'.
Open

    public function show(CorporationInfo $corporation, int $contract_id)
Severity: Minor
Found in src/Http/Controllers/Corporation/ContractsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method getView uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $characters = auth()->user()->characters;
        }
Severity: Minor
Found in src/Http/Controllers/Profile/ProfileController.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method run uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                DB::table('schedules')->insert($job);
            }
Severity: Minor
Found in src/database/seeds/ScheduleSeeder.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$key'.
Open

            ->map(function ($corporation, $key) {
Severity: Minor
Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$key'.
Open

            'results' => $union->get()->map(function ($entity, $key) {
Severity: Minor
Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$request'.
Open

    public function getSearchCharactersData(Request $request)
Severity: Minor
Found in src/Http/Controllers/Support/SearchController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using empty try-catch blocks in getStandingsAjaxElementName.
Open

            } catch (Exception $e) {
            }
Severity: Minor
Found in src/Http/Controllers/Tools/StandingsController.php by phpmd

EmptyCatchBlock

Since: 2.7.0

Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.

Example

class Foo {

  public function bar()
  {
      try {
          // ...
      } catch (Exception $e) {} // empty catch block
  }
}

Source https://phpmd.org/rules/design.html#emptycatchblock

Avoid unused parameters such as '$parameters'.
Open

    public function validate($attribute, $value, $parameters, $validator)
Severity: Minor
Found in src/Http/Validation/Custom/Cron.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$ability'.
Open

    public function before(User $user, string $ability)
Severity: Minor
Found in src/Acl/Policies/SquadPolicy.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$character'.
Open

    public function show(CharacterInfo $character, int $contract_id)
Severity: Minor
Found in src/Http/Controllers/Character/ContractsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$character'.
Open

    public function show(CharacterInfo $character, Killmail $killmail)
Severity: Minor
Found in src/Http/Controllers/Character/KillmailController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language