Sign upLogin

eveseat/web

View on GitHub
Star

Showing 479 of 479 total issues

The method update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {

                        // the permission has been added to the role
                        $role->permissions()->attach($acl_permission->id, [
                            'filters' => $permission_filters,
Severity: Minor
Found in src/Http/Controllers/Configuration/AccessController.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$key'.
Open

        $scopes->transform(function ($item, $key) use ($id) {
Severity: Minor
Found in src/Http/Controllers/Configuration/SsoController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$key'.
Open

            ->map(function ($item, $key) {
Severity: Minor
Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$attribute'.
Open

                function ($attribute, $value, $fail) {
Severity: Minor
Found in src/Http/Validation/CustomSignin.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$key'.
Open

        $trackings = $alliance->corporations->each(function ($corp, $key) use (&$tracked) {
Severity: Minor
Found in src/Http/Controllers/Alliance/AlliancesController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$corporation'.
Open

    public function show(CorporationInfo $corporation, Killmail $killmail)
Severity: Minor
Found in src/Http/Controllers/Corporation/KillmailsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$starbase_id'.
Open

    private function getCorporationStarbases(int $corporation_id, ?int $starbase_id = null)
Severity: Minor
Found in src/Http/Controllers/Corporation/StarbaseController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid assigning values to variables in if clauses and the like (line '92', column '21').
Open

    public function resolveIdsToNames(Request $request)
    {

        // Resolve the Esi client library from the IoC
        $eseye = app('esi-client')->get();
Severity: Minor
Found in src/Http/Controllers/Support/ResolveController.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$attribute'.
Open

    public function validate($attribute, $value, $parameters, $validator)
Severity: Minor
Found in src/Http/Validation/Custom/Cron.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method validate_menu() has an NPath complexity of 8856. The configured NPath complexity threshold is 200.
Open

    public function validate_menu(string $package_name, array $menu_data)
    {

        if (! is_string($package_name))
            throw new PackageMenuBuilderException(
Severity: Minor
Found in src/Http/Composers/AbstractMenu.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid unused local variables such as '$trackings'.
Open

        $trackings = $alliance->corporations->each(function ($corp, $key) use (&$tracked) {
Severity: Minor
Found in src/Http/Controllers/Alliance/AlliancesController.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$key'.
Open

        $deleteKey = $scopes->search(function ($item, $key) use ($id) {
Severity: Minor
Found in src/Http/Controllers/Configuration/SsoController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$corporation'.
Open

    public function getFitting(CorporationInfo $corporation, int $item_id)
Severity: Minor
Found in src/Http/Controllers/Corporation/AssetsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$keyword'.
Open

    public function search($query, string $keyword)
Severity: Minor
Found in src/Http/DataTables/Common/AbstractColumn.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$key'.
Open

            ->map(function ($character, $key) {
Severity: Minor
Found in src/Http/Controllers/Support/FastLookupController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method isEligible uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {

                        $rules = $rules_group;

                        // using group by, we've pair all relationships by their top level relation
Severity: Minor
Found in src/Models/Filterable.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$require_affiliation'.
Open

    public function load_plugin_menu(string $package_name, array $menu_data, bool $require_affiliation = false): ?array
Severity: Minor
Found in src/Http/Composers/AbstractMenu.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused local variables such as '$corporation'.
Open

            ->with('success', sprintf('Alliance %s has been successfully removed.', $corporation->name));
Severity: Minor
Found in src/Http/Controllers/Alliance/AlliancesController.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$character'.
Open

    public function show(CharacterInfo $character, int $mail_id)
Severity: Minor
Found in src/Http/Controllers/Character/MailController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$key'.
Open

        $scopes->transform(function ($item, $key) use ($request) {
Severity: Minor
Found in src/Http/Controllers/Configuration/SsoController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language