Sign upLogin

eveseat/web

View on GitHub
Star

Showing 479 of 479 total issues

Method getCharacterSkillCoverage has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getCharacterSkillCoverage(int $character_id): Collection
    {

        $in_game_skills = DB::table('invTypes')
            ->join(
Severity: Major
Found in src/Traits/Stats.php - About 2 hrs to fix

    Method ajax has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function ajax()
    {
        $location_column = $this->getLocationFlagColumn($this);
        $station_column = $this->getStationColumn($this);
    Severity: Minor
    Found in src/Http/DataTables/Common/Intel/AbstractAssetDataTable.php - About 2 hrs to fix

      Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function ajax()
    {

        return datatables()
            ->eloquent($this->applyScopes($this->query()))
      Severity: Minor
      Found in src/Http/DataTables/Common/Intel/AbstractContactDataTable.php - About 1 hr to fix

        Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function ajax()
    {
        return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->editColumn('planet.name', function ($row) {
        Severity: Minor
        Found in src/Http/DataTables/Corporation/Industrial/CustomOfficeDataTable.php - About 1 hr to fix

          Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function ajax()
    {
        return datatables()->eloquent($this->query())
            ->editColumn('users.name', function ($row) {
                $main_character = new CharacterInfo([
          Severity: Minor
          Found in src/Http/DataTables/Configuration/UsersDataTable.php - About 1 hr to fix

            Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function ajax()
    {
        return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->editColumn('date', function ($row) {
            Severity: Minor
            Found in src/Http/DataTables/Common/Financial/AbstractWalletJournalDataTable.php - About 1 hr to fix

              Function register_policies has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function register_policies()
    {
        $permissions = config('seat.permissions', []);

        Gate::define('global.superuser', 'Seat\Web\Acl\Policies\GlobalPolicy@superuser');
              Severity: Minor
              Found in src/WebServiceProvider.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method resolveIdsToNames has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function resolveIdsToNames(Request $request)
    {

        // Resolve the Esi client library from the IoC
        $eseye = app('esi-client')->get();
              Severity: Minor
              Found in src/Http/Controllers/Support/ResolveController.php - About 1 hr to fix

                Method getJournalContent has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getJournalContent(CharacterInfo $character, int $first_party_id, int $second_party_id, string $ref_type)
    {

        $character_ids = collect($character->character_id);
                Severity: Minor
                Found in src/Http/Controllers/Character/IntelController.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php

/*
 * This file is part of SeAT
 *
                  Severity: Major
                  Found in src/Http/Controllers/Corporation/IndustryController.php and 1 other location - About 1 hr to fix
                  src/Http/Controllers/Corporation/ContactsController.php on lines 1..52

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php

/*
 * This file is part of SeAT
 *
                  Severity: Major
                  Found in src/Http/Controllers/Corporation/ContactsController.php and 1 other location - About 1 hr to fix
                  src/Http/Controllers/Corporation/IndustryController.php on lines 1..51

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method ajax has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function ajax()
    {
        return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->addColumn('is_candidate', function ($row) {
                  Severity: Minor
                  Found in src/Http/DataTables/Squads/SquadsDataTable.php - About 1 hr to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            if ($this->requested_characters != null) {
            $character_ids = collect($this->requested_characters)->filter(function ($item) {
                return Gate::allows($this->ability, [$item]);
            });
                    Severity: Major
                    Found in src/Http/DataTables/Scopes/CharacterScope.php and 2 other locations - About 1 hr to fix
                    src/Http/DataTables/Scopes/AllianceScope.php on lines 71..79
                    src/Http/DataTables/Scopes/CorporationScope.php on lines 73..81

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 117.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            if ($this->requested_alliances != null) {
            $alliance_ids = collect($this->requested_alliances)->filter(function ($item) {
                return Gate::allows($this->ability, [$item]);
            });
                    Severity: Major
                    Found in src/Http/DataTables/Scopes/AllianceScope.php and 2 other locations - About 1 hr to fix
                    src/Http/DataTables/Scopes/CharacterScope.php on lines 74..82
                    src/Http/DataTables/Scopes/CorporationScope.php on lines 73..81

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 117.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            if ($this->requested_corporations != null) {
            $corporation_ids = collect($this->requested_corporations)->filter(function ($item) {
                return Gate::allows($this->ability, [$item]);
            });
                    Severity: Major
                    Found in src/Http/DataTables/Scopes/CorporationScope.php and 2 other locations - About 1 hr to fix
                    src/Http/DataTables/Scopes/AllianceScope.php on lines 71..79
                    src/Http/DataTables/Scopes/CharacterScope.php on lines 74..82

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 117.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method ajax has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function ajax()
    {
        return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->editColumn('moon.region.name', function ($row) {
                    Severity: Minor
                    Found in src/Http/DataTables/Tools/MoonsDataTable.php - About 1 hr to fix

                      Method getTopWalletJournalData has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function getTopWalletJournalData(CharacterInfo $character)
    {

        if (! request()->has('characters'))
            return abort(500);
                      Severity: Minor
                      Found in src/Http/Controllers/Character/IntelController.php - About 1 hr to fix

                        Method getStandingsAjaxElementName has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getStandingsAjaxElementName(Request $request)
    {

        $response = [
            'results' => [],
                        Severity: Minor
                        Found in src/Http/Controllers/Tools/StandingsController.php - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->editColumn('issued', function ($row) {
                return view('web::partials.date', ['datetime' => $row->issued])->render();
            })
                          Severity: Major
                          Found in src/Http/DataTables/Common/Financial/AbstractMarketDataTable.php and 1 other location - About 1 hr to fix
                          src/Http/DataTables/Common/Financial/AbstractWalletTransactionDataTable.php on lines 41..89

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 116.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Method validate_menu has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function validate_menu(string $package_name, array $menu_data)
    {

        if (! is_string($package_name))
            throw new PackageMenuBuilderException(
                          Severity: Minor
                          Found in src/Http/Composers/AbstractMenu.php - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language