Showing 479 of 479 total issues
Method getCharacterSkillCoverage
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCharacterSkillCoverage(int $character_id): Collection
{
$in_game_skills = DB::table('invTypes')
->join(
Method ajax
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function ajax()
{
$location_column = $this->getLocationFlagColumn($this);
$station_column = $this->getStationColumn($this);
Method ajax
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function ajax()
{
return datatables()
->eloquent($this->applyScopes($this->query()))
Method ajax
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function ajax()
{
return datatables()
->eloquent($this->applyScopes($this->query()))
->editColumn('planet.name', function ($row) {
Method ajax
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function ajax()
{
return datatables()->eloquent($this->query())
->editColumn('users.name', function ($row) {
$main_character = new CharacterInfo([
Method ajax
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function ajax()
{
return datatables()
->eloquent($this->applyScopes($this->query()))
->editColumn('date', function ($row) {
Function register_policies
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
private function register_policies()
{
$permissions = config('seat.permissions', []);
Gate::define('global.superuser', 'Seat\Web\Acl\Policies\GlobalPolicy@superuser');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method resolveIdsToNames
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function resolveIdsToNames(Request $request)
{
// Resolve the Esi client library from the IoC
$eseye = app('esi-client')->get();
Method getJournalContent
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getJournalContent(CharacterInfo $character, int $first_party_id, int $second_party_id, string $ref_type)
{
$character_ids = collect($character->character_id);
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
/*
* This file is part of SeAT
*
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 118.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
/*
* This file is part of SeAT
*
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 118.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method ajax
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function ajax()
{
return datatables()
->eloquent($this->applyScopes($this->query()))
->addColumn('is_candidate', function ($row) {
Similar blocks of code found in 3 locations. Consider refactoring. Open
if ($this->requested_characters != null) {
$character_ids = collect($this->requested_characters)->filter(function ($item) {
return Gate::allows($this->ability, [$item]);
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 117.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if ($this->requested_alliances != null) {
$alliance_ids = collect($this->requested_alliances)->filter(function ($item) {
return Gate::allows($this->ability, [$item]);
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 117.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if ($this->requested_corporations != null) {
$corporation_ids = collect($this->requested_corporations)->filter(function ($item) {
return Gate::allows($this->ability, [$item]);
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 117.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method ajax
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function ajax()
{
return datatables()
->eloquent($this->applyScopes($this->query()))
->editColumn('moon.region.name', function ($row) {
Method getTopWalletJournalData
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getTopWalletJournalData(CharacterInfo $character)
{
if (! request()->has('characters'))
return abort(500);
Method getStandingsAjaxElementName
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getStandingsAjaxElementName(Request $request)
{
$response = [
'results' => [],
Similar blocks of code found in 2 locations. Consider refactoring. Open
return datatables()
->eloquent($this->applyScopes($this->query()))
->editColumn('issued', function ($row) {
return view('web::partials.date', ['datetime' => $row->issued])->render();
})
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 116.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method validate_menu
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function validate_menu(string $package_name, array $menu_data)
{
if (! is_string($package_name))
throw new PackageMenuBuilderException(