Sign upLogin

eveseat/web

View on GitHub
Star

Showing 479 of 479 total issues

Avoid excessively long variable names like $director_roles_corporations. Keep variable name length under 20.
Open

        $director_roles_corporations = CorporationRole::whereIn('corporation_id', $associated_corporations)->whereIn('character_id', $owned_range)
Severity: Minor
Found in src/Http/DataTables/Scopes/CharacterNoteScope.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $total_character_skillpoints. Keep variable name length under 20.
Open

        $total_character_skillpoints = $this->getTotalCharacterSkillpoints($characterIds);
Severity: Minor
Found in src/Http/Controllers/HomeController.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $associated_ceo_corporations. Keep variable name length under 20.
Open

        $associated_ceo_corporations = CorporationInfo::whereIn('ceo_id', $owned_range)->get();
Severity: Minor
Found in src/Http/DataTables/Scopes/CharacterNoteScope.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $director_corporations. Keep variable name length under 20.
Open

        $director_corporations = CorporationInfo::with('characters')->whereIn('corporation_id', $director_roles_corporations)->get();
Severity: Minor
Found in src/Http/DataTables/Scopes/CharacterScope.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $associated_corporations. Keep variable name length under 20.
Open

        $associated_corporations = auth()->user()->characters->load('affiliation')->pluck('affiliation.corporation_id')->values()->toArray();
Severity: Minor
Found in src/Http/DataTables/Scopes/CharacterNoteScope.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $custom_signin_message. Keep variable name length under 20.
Open

        $custom_signin_message = setting('custom_signin_message', true);
Severity: Minor
Found in src/Http/Controllers/Auth/LoginController.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $associated_ceo_corporations. Keep variable name length under 20.
Open

        $associated_ceo_corporations = CorporationInfo::whereIn('ceo_id', $owned_range)->get();
Severity: Minor
Found in src/Http/DataTables/Scopes/CharacterScope.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method getCharacterMailTimeline has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getCharacterMailTimeline(int $message_id = null)
    {
        // Get the User for permissions and affiliation
        // checks
        $user = auth()->user();
Severity: Minor
Found in src/Http/Controllers/Character/MailController.php - About 1 hr to fix

    Method apply has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function apply($query)
    {
        return $query->whereHas('recipients', function ($sub_query) {

            if ($this->requested_characters != null) {
    Severity: Minor
    Found in src/Http/DataTables/Scopes/CharacterMailScope.php - About 1 hr to fix

      Method getTopTransactionsData has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getTopTransactionsData(CharacterInfo $character)
    {

        if (! request()->has('characters'))
            return abort(500);
      Severity: Minor
      Found in src/Http/Controllers/Character/IntelController.php - About 1 hr to fix

        Function index has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function index(Request $request)
    {
        $squads = Squad::with('members', 'moderators', 'applications');

        if ($request->has('filters')) {
        Severity: Minor
        Found in src/Http/Controllers/Squads/SquadsController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->editColumn('date', function ($row) {
                return view('web::partials.date', ['datetime' => $row->date])->render();
            })
        Severity: Major
        Found in src/Http/DataTables/Common/Financial/AbstractWalletJournalDataTable.php and 2 other locations - About 1 hr to fix
        src/Http/DataTables/Common/Financial/AbstractWalletJournalDataTable.php on lines 42..79
        src/Http/DataTables/Common/Financial/AbstractWalletTransactionDataTable.php on lines 41..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->editColumn('date', function ($row) {
                return view('web::partials.date', ['datetime' => $row->date])->render();
            })
        Severity: Major
        Found in src/Http/DataTables/Common/Financial/AbstractWalletTransactionDataTable.php and 2 other locations - About 1 hr to fix
        src/Http/DataTables/Common/Financial/AbstractWalletJournalDataTable.php on lines 42..67
        src/Http/DataTables/Common/Financial/AbstractWalletJournalDataTable.php on lines 42..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method getCharacterJournalStandingsWithProfile has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getCharacterJournalStandingsWithProfile(int $character_id, int $profile_id)
    {

        return CharacterAffiliation::with('character', 'corporation', 'alliance', 'faction')
            ->select(
        Severity: Minor
        Found in src/Http/Controllers/Character/IntelController.php - About 1 hr to fix

          Method apply has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function apply($query)
    {
        // extract querying table (from)
        $table = $query->getQuery()->from;
          Severity: Minor
          Found in src/Http/DataTables/Scopes/CorporationScope.php - About 1 hr to fix

            Method getTopMailContent has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getTopMailContent(CharacterInfo $character, int $from)
    {

        $character_ids = collect($character->character_id);
            Severity: Minor
            Found in src/Http/Controllers/Character/IntelController.php - About 1 hr to fix

              Method isEligible has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  final public function isEligible(Model $member): bool
    {
        // in case no filters exists, bypass check
        if (! property_exists($this->getFilters(), 'and') && ! property_exists($this->getFilters(), 'or'))
            return true;
              Severity: Minor
              Found in src/Models/Filterable.php - About 1 hr to fix

                Method ajax has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function ajax()
    {
        return datatables()
            ->eloquent($this->applyScopes($this->query()))
            ->editColumn('category', function ($row) {
                Severity: Minor
                Found in src/Http/DataTables/Tools/StandingsDataTable.php - About 1 hr to fix

                  Method getSearchCharacterAssetsData has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getSearchCharacterAssetsData(Request $request)
    {
        $scope = new CharacterScope('character.asset');

        $query = CharacterAsset::with('character', 'type', 'type.group', 'station', 'container', 'container.station',
                  Severity: Minor
                  Found in src/Http/Controllers/Support/SearchController.php - About 1 hr to fix

                    Function draw has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function draw(Model $row)
    {
        // in case the location is in station range -> use station relation.
        if ($row->location_id < 64000000)
            return $row->station->name;
                    Severity: Minor
                    Found in src/Http/DataTables/Character/Industrial/Blueprints/Columns/Station.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language