Sign upLogin

ezeql/wiw-scheduler-api

View on GitHub
Star

Showing 26 of 26 total issues

Method Shift.UnmarshalJSON has 8 return statements (exceeds 4 allowed).
Open

func (s *Shift) UnmarshalJSON(b []byte) error {
    const rfc2822Layout = "Mon Jan 02 15:04:05 -0700 2006"
    var parsed map[string]interface{}

    if err := json.Unmarshal(b, &parsed); err != nil {
Severity: Major
Found in wiw/shift.go - About 50 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (ss *schedulerService) ViewColleagues(c *gin.Context) {
    colleages, err := ss.repository.ColleaguesForUser(c.MustGet("id").(int))
    if err != nil {
        ss.handleError(c, err)
        return
    Severity: Major
    Found in main.go and 2 other locations - About 45 mins to fix
    main.go on lines 81..88
    main.go on lines 127..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (ss *schedulerService) ViewManagers(c *gin.Context) {
    managers, err := ss.repository.ManagersForUser(c.MustGet("id").(int))
    if err != nil {
        ss.handleError(c, err)
        return
    Severity: Major
    Found in main.go and 2 other locations - About 45 mins to fix
    main.go on lines 72..79
    main.go on lines 127..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (ss *schedulerService) ViewUser(c *gin.Context) {
    user, err := ss.repository.UserDetails(c.MustGet("id").(int))
    if err != nil {
        ss.handleError(c, err)
        return
    Severity: Major
    Found in main.go and 2 other locations - About 45 mins to fix
    main.go on lines 72..79
    main.go on lines 81..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 3 places. Go fmt your code!
    Open

    package wiw
    Severity: Minor
    Found in wiw/shift.go by gofmt

    Your code does not pass gofmt in 2 places. Go fmt your code!
    Open

    package wiw
    Severity: Minor
    Found in wiw/mysqlrepo.go by gofmt

    exported method MySQLRepository.ShiftsForUser should have comment or be unexported
    Open

    func (r *MySQLRepository) ShiftsForUser(ID int) ([]Shift, error) {
    Severity: Minor
    Found in wiw/mysqlrepo.go by golint

    exported const WorkHoursPerDay should have comment or be unexported
    Open

    const WorkHoursPerDay = 8
    Severity: Minor
    Found in wiw/shift.go by golint

    exported method MySQLRepository.UserDetails should have comment or be unexported
    Open

    func (r *MySQLRepository) UserDetails(ID int) (User, error) {
    Severity: Minor
    Found in wiw/mysqlrepo.go by golint

    comment on exported const HoursPerWeek should be of the form "HoursPerWeek ..."
    Open

    //used for calculating hours worked in a whole week.
    Severity: Minor
    Found in wiw/shift.go by golint

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package wiw
    Severity: Minor
    Found in wiw/common.go by gofmt

    exported function ISOWeeksCount should have comment or be unexported
    Open

    func ISOWeeksCount(y int) int {
    Severity: Minor
    Found in wiw/common.go by golint

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package wiw
    Severity: Minor
    Found in wiw/repository.go by gofmt

    exported type ColleaguesResult should have comment or be unexported
    Open

    type ColleaguesResult struct {
    Severity: Minor
    Found in wiw/common.go by golint

    exported function SummarizeShifts should have comment or be unexported
    Open

    func SummarizeShifts(shifts []Shift) map[string][]float64 {
    Severity: Minor
    Found in wiw/shift.go by golint

    exported method MySQLRepository.UpdateOrCreateShift should have comment or be unexported
    Open

    func (r *MySQLRepository) UpdateOrCreateShift(shift *Shift) error {
    Severity: Minor
    Found in wiw/mysqlrepo.go by golint

    exported method MySQLRepository.CreateShift should have comment or be unexported
    Open

    func (r *MySQLRepository) CreateShift(shift *Shift) error {
    Severity: Minor
    Found in wiw/mysqlrepo.go by golint

    exported method MySQLRepository.ManagersForUser should have comment or be unexported
    Open

    func (r *MySQLRepository) ManagersForUser(ID int) ([]User, error) {
    Severity: Minor
    Found in wiw/mysqlrepo.go by golint

    exported type UserShift should have comment or be unexported
    Open

    type UserShift struct {
    Severity: Minor
    Found in wiw/common.go by golint

    exported method MySQLRepository.ColleaguesForUser should have comment or be unexported
    Open

    func (r *MySQLRepository) ColleaguesForUser(ID int) ([]ColleaguesResult, error) {
    Severity: Minor
    Found in wiw/mysqlrepo.go by golint
    Severity
    Category
    Status
    Source
    Language