Sign upLogin

ezseed/database

View on GitHub
Star

Showing 29 of 29 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

albums.songs = {
  add: function(id, song, done) {

    var next = function(song, cb) {
      Albums
Severity: Major
Found in lib/files/albums.js and 1 other location - About 1 day to fix
lib/files/others.js on lines 8..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 263.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

others.files = {
  add: function(id, file, done) {

    var next = function(file, cb) {
      Others
Severity: Major
Found in lib/files/others.js and 1 other location - About 1 day to fix
lib/files/albums.js on lines 8..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 263.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function files has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

  files: function (uid, params, done) {

    this.paths(uid, params, function(err, docs) {

      if(err) {
Severity: Minor
Found in lib/user.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function is_watched has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  is_watched: function(path, options, done) {

    var is_watched = [], which, id_path

    if(typeof options == 'function')
Severity: Minor
Found in lib/paths.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function files has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  files: function (uid, params, done) {

    this.paths(uid, params, function(err, docs) {

      if(err) {
Severity: Major
Found in lib/user.js - About 3 hrs to fix

    Function exports has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function(type) {
    var debug = require('debug')('ezseed:database:'+type)
  var file_type = helpers.filename(type)

  var item = {
    Severity: Minor
    Found in lib/files.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              models[type].create(item, function(err, item) {
            if(err)
              return cb(err)

            debug('item created')
    Severity: Major
    Found in lib/files.js and 1 other location - About 2 hrs to fix
    lib/files/movies.js on lines 120..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            Movies.create(movie, function(err, movie) {
          if(err)
            return cb(err)

          debug('movie created')
    Severity: Major
    Found in lib/files/movies.js and 1 other location - About 2 hrs to fix
    lib/files.js on lines 55..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File user.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var models = require('../models')
  , Paths = models.paths
  , Users = models.users
  , File = models.file
  , Movies = models.movies
    Severity: Minor
    Found in lib/user.js - About 2 hrs to fix

      Function exports has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(search_string) {
    var keys = {
      movies: ['name', 'format', 'subtitles', 'audio', 'quality'],
      albums: ['artist', 'album'],
      others: ['name']
      Severity: Minor
      Found in lib/search.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(type) {
    var debug = require('debug')('ezseed:database:'+type)
  var file_type = helpers.filename(type)

  var item = {
      Severity: Major
      Found in lib/files.js - About 2 hrs to fix

        Function save has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          save: function (movies, id_path, done) {

    done = typeof id_path == 'function' ? id_path : done

    var create = function(movie, cb) {
        Severity: Minor
        Found in lib/files/movies.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function remove has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          remove: function(path, options, done) {

    var deleted_paths = []

    if(typeof options == 'function') {
        Severity: Minor
        Found in lib/paths.js - About 2 hrs to fix

          Function is_watched has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            is_watched: function(path, options, done) {

    var is_watched = [], which, id_path

    if(typeof options == 'function')
          Severity: Minor
          Found in lib/paths.js - About 1 hr to fix

            Function save has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              save: function (movies, id_path, done) {

    done = typeof id_path == 'function' ? id_path : done

    var create = function(movie, cb) {
            Severity: Minor
            Found in lib/files/movies.js - About 1 hr to fix

              Function save has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                save: function(path, options, done) {
    if(!path) 
      throw new Error('No path to be saved')

    var user = require('./user')
              Severity: Minor
              Found in lib/paths.js - About 1 hr to fix

                Function exports has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function(search_string) {
    var keys = {
      movies: ['name', 'format', 'subtitles', 'audio', 'quality'],
      albums: ['artist', 'album'],
      others: ['name']
                Severity: Minor
                Found in lib/search.js - About 1 hr to fix

                  Function delete has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    delete: function(id, done) {
    debug('Deleting movie')

    item.get(id, function(err, movie) {
                  Severity: Minor
                  Found in lib/files/movies.js - About 1 hr to fix

                    Function delete has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                      delete: function(id, done) {
    debug('Deleting movie')

    item.get(id, function(err, movie) {
                    Severity: Minor
                    Found in lib/files/movies.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function save has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        save: function (items, id_path, done) {

      done = typeof id_path == 'function' ? id_path : done

      var next = function(item, cb) {
                    Severity: Minor
                    Found in lib/files.js - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language