ezseed/database

View on GitHub

Showing 29 of 29 total issues

Function set has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  set: function(type) {

    debug('set %s to remove', type)

    return function(item, done) {
Severity: Minor
Found in lib/remove.js - About 1 hr to fix

    Function create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      create: function(u, done) {
        var password = u.password, username = u.username
    
        //Generates the hash
        bcrypt.hash(password, null, null, function(err, hash) {
    Severity: Minor
    Found in lib/user.js - About 1 hr to fix

      Function paths has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        paths: function(value, options, done) {
      
          done = typeof options == 'function' ? options : done
          options = typeof options == 'function' ? {} : options
      
      
      Severity: Minor
      Found in lib/user.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

         exists: function(path, done) {
            Paths.count({path: path}, function(err, count) {
              if(count)
                done(true)
              else
      Severity: Minor
      Found in lib/paths.js and 1 other location - About 55 mins to fix
      lib/user.js on lines 21..28

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        exists: function(username, done) {
          Users.count({username: username}, function(err, count) {
            if(count)
              done(true)
            else
      Severity: Minor
      Found in lib/user.js and 1 other location - About 55 mins to fix
      lib/paths.js on lines 16..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function login has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        login: function(user, done) {
      
          if(!user.password || !user.username) {
            return done('Missing password or username')
          }
      Severity: Minor
      Found in lib/user.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function set has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        set: function(type) {
      
          debug('set %s to remove', type)
      
          return function(item, done) {
      Severity: Minor
      Found in lib/remove.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        save: function(path, options, done) {
          if(!path) 
            throw new Error('No path to be saved')
      
          var user = require('./user')
      Severity: Minor
      Found in lib/paths.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function remove has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        remove: function(path, options, done) {
      
          var deleted_paths = []
      
          if(typeof options == 'function') {
      Severity: Minor
      Found in lib/paths.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language