fabiocicerchia/go-proxy-cache

View on GitHub

Showing 21 of 21 total issues

File metrics.go has 533 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package metrics

import (
    "fmt"
    "net/http"
Severity: Minor
Found in telemetry/metrics/metrics.go - About 2 hrs to fix

    Function IncWholeResponse has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func IncWholeResponse(reqID string, req http.Request, statusCode int, size int, duration int64, scheme string, cached bool, stale bool) {
    Severity: Major
    Found in telemetry/metrics/metrics.go - About 1 hr to fix

      Method TelemetryContext.RegisterWholeResponse has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (tc TelemetryContext) RegisterWholeResponse(reqID string, req http.Request, statusCode int, contentLength int, requestStartTime time.Time, scheme string, cached bool, stale bool) {
      Severity: Major
      Found in telemetry/telemetry.go - About 1 hr to fix

        Method TelemetryContext.RegisterLegitRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (tc TelemetryContext) RegisterLegitRequest(hostMatch bool, legitPort bool, hostname string, listeningPort string, confHostname string, confPort string) {
        Severity: Minor
        Found in telemetry/telemetry.go - About 45 mins to fix

          Function StoreMetadata has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func StoreMetadata(ctx context.Context, domainID string, method string, url url.URL, meta []string, expiration time.Duration) (bool, error) {
          Severity: Minor
          Found in cache/cache.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                } else if code < 600 {
                    request5xx.With(labels).Inc()
                }
            Severity: Major
            Found in telemetry/metrics/metrics.go - About 45 mins to fix

              Method Object.StoreFullPage has 6 return statements (exceeds 4 allowed).
              Open

              func (c Object) StoreFullPage(ctx context.Context, expiration time.Duration) (bool, error) {
                  if !c.IsStatusAllowed() || !c.IsMethodAllowed() || expiration < 1 {
                      logger.GetGlobal().WithFields(log.Fields{
                          "ReqID": c.ReqID,
                      }).Debugf(
              Severity: Major
              Found in cache/cache.go - About 40 mins to fix

                Method Object.RetrieveFullPage has 6 return statements (exceeds 4 allowed).
                Open

                func (c *Object) RetrieveFullPage() error {
                    obj := &URIObj{}
                
                    meta, err := FetchMetadata(c.DomainID, c.CurrentURIObject.Method, c.CurrentURIObject.URL)
                    if err != nil {
                Severity: Major
                Found in cache/cache.go - About 40 mins to fix

                  Function LogRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func LogRequest(req http.Request, statusCode int, lenContent int, reqID string, cacheLabel int) {
                  Severity: Minor
                  Found in logger/log.go - About 35 mins to fix

                    Method TelemetryContext.RegisterRequestCall has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (tc TelemetryContext) RegisterRequestCall(reqID string, req http.Request, reqURL url.URL, scheme string, webSocket bool) {
                    Severity: Minor
                    Found in telemetry/telemetry.go - About 35 mins to fix

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      func InitRandom(name string, config config.Upstream, enableHealthchecks bool) {
                          initLB()
                          items := convertEndpoints(config.Endpoints)
                      
                          lb[name] = NewRandomBalancer(name, items)
                      Severity: Major
                      Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
                      server/balancer/balancer.go on lines 68..77
                      server/balancer/balancer.go on lines 92..101
                      server/balancer/balancer.go on lines 104..113

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      func InitIpHash(name string, config config.Upstream, enableHealthchecks bool) {
                          initLB()
                          items := convertEndpoints(config.Endpoints)
                      
                          lb[name] = NewIpHashBalancer(name, items)
                      Severity: Major
                      Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
                      server/balancer/balancer.go on lines 68..77
                      server/balancer/balancer.go on lines 80..89
                      server/balancer/balancer.go on lines 92..101

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      func InitRoundRobin(name string, config config.Upstream, enableHealthchecks bool) {
                          initLB()
                          items := convertEndpoints(config.Endpoints)
                      
                          lb[name] = NewRoundRobinBalancer(name, items)
                      Severity: Major
                      Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
                      server/balancer/balancer.go on lines 80..89
                      server/balancer/balancer.go on lines 92..101
                      server/balancer/balancer.go on lines 104..113

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      func InitLeastConnection(name string, config config.Upstream, enableHealthchecks bool) {
                          initLB()
                          items := convertEndpoints(config.Endpoints)
                      
                          lb[name] = NewLeastConnectionsBalancer(name, items)
                      Severity: Major
                      Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
                      server/balancer/balancer.go on lines 68..77
                      server/balancer/balancer.go on lines 80..89
                      server/balancer/balancer.go on lines 104..113

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      func SetUpstreamServerHealthChecksHealthy(server string, upstream string) {
                          hostname, _ := os.Hostname()
                          labels := prometheus.Labels{
                              "hostname": hostname,
                              "env":      os.Getenv("TRACING_ENV"),
                      Severity: Minor
                      Found in telemetry/metrics/metrics.go and 1 other location - About 35 mins to fix
                      telemetry/metrics/metrics.go on lines 613..625

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 104.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      func SetUpstreamServerHealthChecksUnhealthy(server string, upstream string) {
                          hostname, _ := os.Hostname()
                          labels := prometheus.Labels{
                              "hostname": hostname,
                              "env":      os.Getenv("TRACING_ENV"),
                      Severity: Minor
                      Found in telemetry/metrics/metrics.go and 1 other location - About 35 mins to fix
                      telemetry/metrics/metrics.go on lines 583..595

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 104.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if ok, err := rdb.getMutex(key).Unlock(); !ok || err != nil {
                              escapedKey := strings.Replace(key, "\n", "", -1)
                              escapedKey = strings.Replace(escapedKey, "\r", "", -1)
                              rdb.logger.Errorf("Unlock Error on %s: %s", escapedKey, err)
                              telemetry.From(ctx).RegisterEventWithData("Lock Error", map[string]string{
                      Severity: Minor
                      Found in cache/engine/client/client.go and 1 other location - About 30 mins to fix
                      cache/engine/client/client.go on lines 79..88

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 102.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if err := rdb.getMutex(key).Lock(); err != nil {
                              escapedKey := strings.Replace(key, "\n", "", -1)
                              escapedKey = strings.Replace(escapedKey, "\r", "", -1)
                              rdb.logger.Errorf("Lock Error on %s: %s", escapedKey, err)
                              telemetry.From(ctx).RegisterEventWithData("Lock Error", map[string]string{
                      Severity: Minor
                      Found in cache/engine/client/client.go and 1 other location - About 30 mins to fix
                      cache/engine/client/client.go on lines 94..103

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 102.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                      func IncUpstreamServerResponseTime(server string, upstream string, val float64) {
                          hostname, _ := os.Hostname()
                          labels := prometheus.Labels{
                              "hostname": hostname,
                              "env":      os.Getenv("TRACING_ENV"),
                      Severity: Minor
                      Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
                      telemetry/metrics/metrics.go on lines 506..516
                      telemetry/metrics/metrics.go on lines 519..529

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                      func IncUpstreamServerReceived(server string, upstream string, val float64) {
                          hostname, _ := os.Hostname()
                          labels := prometheus.Labels{
                              "hostname": hostname,
                              "env":      os.Getenv("TRACING_ENV"),
                      Severity: Minor
                      Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
                      telemetry/metrics/metrics.go on lines 506..516
                      telemetry/metrics/metrics.go on lines 532..541

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language