Sign upLogin

fapi-cz/http-client

View on GitHub
Star

Showing 24 of 24 total issues

Method preProcessHeaders has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function preProcessHeaders(array $options, StreamInterface|string &$body): array
    {
        $data = self::$defaults;

        if (isset($options['form_params'])) {
Severity: Major
Found in src/Fapi/HttpClient/HttpRequest.php - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private function processBody(string $body): string
    {
        if (strlen($body) <= $this->maxBodyLength) {
            return $body;
        }
    Severity: Major
    Found in src/Fapi/HttpClient/LoggingFormatters/BaseLoggingFormatter.php and 1 other location - About 1 hr to fix
    src/Fapi/HttpClient/LoggingFormatters/JsonLoggingFormatter.php on lines 69..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function getResources(string $path, array $parameters = []): array
    {
        if ($parameters !== []) {
            $path .= '?' . $this->formatUrlParameters($parameters);
        }
    Severity: Major
    Found in src/Fapi/HttpClient/Rest/RestClient.php and 1 other location - About 1 hr to fix
    src/Fapi/HttpClient/Rest/RestClient.php on lines 86..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private function processBody(string $body): string
    {
        if (strlen($body) <= $this->maxBodyLength) {
            return $body;
        }
    Severity: Major
    Found in src/Fapi/HttpClient/LoggingFormatters/JsonLoggingFormatter.php and 1 other location - About 1 hr to fix
    src/Fapi/HttpClient/LoggingFormatters/BaseLoggingFormatter.php on lines 95..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function getSingularResource(string $path, array $parameters = []): array
    {
        if ($parameters !== []) {
            $path .= '?' . $this->formatUrlParameters($parameters);
        }
    Severity: Major
    Found in src/Fapi/HttpClient/Rest/RestClient.php and 1 other location - About 1 hr to fix
    src/Fapi/HttpClient/Rest/RestClient.php on lines 38..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method writeToPhpFile has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function writeToPhpFile(string $fileName, string $className): void
    {
        preg_match('#^(?:(.*)\\\\)?([^\\\\]+)\z#', $className, $match);
        [, $namespace, $className] = $match;
    Severity: Minor
    Found in src/Fapi/HttpClient/CapturingHttpClient.php - About 1 hr to fix

      Method loadConfiguration has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function loadConfiguration(): void
    {
        $container = $this->getContainerBuilder();
        $config = $this->validateConfig($this->defaults);
      Severity: Minor
      Found in src/Fapi/HttpClient/Bridges/NetteDI/HttpClientExtension.php - About 1 hr to fix

        Function validateHeadersOption has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function validateHeadersOption(mixed $headers): void
    {
        if (!is_array($headers)) {
            throw new InvalidArgumentException('Headers must be an array.');
        }
        Severity: Minor
        Found in src/Fapi/HttpClient/HttpRequest.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method isMatching has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function isMatching(string $pattern, string $actual, bool $strict = false): bool
    {
        $old = ini_set('pcre.backtrack_limit', '10000000');

        if (!self::isPcre($pattern)) {
        Severity: Minor
        Found in src/Fapi/HttpClient/MockHttpClient.php - About 1 hr to fix

          Method decode has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function decode(string $json, int $options = 0): mixed
    {
        if (!(bool) preg_match('##u', $json)) {
            throw new JsonException('Invalid UTF-8 sequence', 5); // workaround for PHP < 5.3.3 & PECL JSON-C
        }
          Severity: Minor
          Found in src/Fapi/HttpClient/Utils/Json.php - About 1 hr to fix

            Function validateSslKeyOption has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function validateSslKeyOption(mixed $value): void
    {
        if (!is_string($value) && !is_array($value)) {
            throw new InvalidArgumentException('Option ssl_key must be a string.');
        }
            Severity: Minor
            Found in src/Fapi/HttpClient/HttpRequest.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function preProcessHeaders has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function preProcessHeaders(array $options, StreamInterface|string &$body): array
    {
        $data = self::$defaults;

        if (isset($options['form_params'])) {
            Severity: Minor
            Found in src/Fapi/HttpClient/HttpRequest.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateCertOption has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function validateCertOption(mixed $value): void
    {
        if (!is_string($value) && !is_array($value)) {
            throw new InvalidArgumentException('Option cert must be a string.');
        }
            Severity: Minor
            Found in src/Fapi/HttpClient/HttpRequest.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method encode has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function encode(mixed $value, int $options = 0): string
    {
        $flags = PHP_VERSION_ID >= 50400
            ? (JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES |
                (
            Severity: Minor
            Found in src/Fapi/HttpClient/Utils/Json.php - About 1 hr to fix

              Method validateCertOption has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private static function validateCertOption(mixed $value): void
    {
        if (!is_string($value) && !is_array($value)) {
            throw new InvalidArgumentException('Option cert must be a string.');
        }
              Severity: Minor
              Found in src/Fapi/HttpClient/HttpRequest.php - About 1 hr to fix

                Function validateHeaders has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private static function validateHeaders(array $headers): void
    {
        foreach ($headers as $values) {
            if (!is_array($values)) {
                throw new InvalidArgumentException('Header values must be an array.');
                Severity: Minor
                Found in src/Fapi/HttpClient/HttpResponse.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function processOptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function processOptions(RequestInterface $request, CurlHandle $handle): void
    {
        if ($request->hasHeader('timeout')) {
            curl_setopt($handle, CURLOPT_TIMEOUT, (int) $request->getHeaderLine('timeout'));
        }
                Severity: Minor
                Found in src/Fapi/HttpClient/CurlHttpClient.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ($request->hasHeader('cert')) {
            curl_setopt($handle, CURLOPT_SSLCERT, $request->getHeader('cert')[0]);

            if ((bool) ($request->getHeader('cert')[1] ?? false)) {
                curl_setopt($handle, CURLOPT_SSLCERTPASSWD, $request->getHeader('cert')[1]);
                Severity: Minor
                Found in src/Fapi/HttpClient/CurlHttpClient.php and 1 other location - About 40 mins to fix
                src/Fapi/HttpClient/CurlHttpClient.php on lines 130..136

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ($request->hasHeader('ssl_key')) {
            curl_setopt($handle, CURLOPT_SSLKEY, $request->getHeader('ssl_key')[0]);

            if ((bool) ($request->getHeader('ssl_key')[1] ?? false)) {
                curl_setopt($handle, CURLOPT_SSLKEYPASSWD, $request->getHeader('ssl_key')[1]);
                Severity: Minor
                Found in src/Fapi/HttpClient/CurlHttpClient.php and 1 other location - About 40 mins to fix
                src/Fapi/HttpClient/CurlHttpClient.php on lines 122..128

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        string $method,
        UriInterface|string $uri,
        array $headers = [],
        StreamInterface|string|null $body = null,
        string $version = '1.1',
                Severity: Minor
                Found in src/Fapi/HttpClient/HttpRequest.php - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language