fapi-cz/http-client

View on GitHub

Showing 24 of 24 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        int $status = 200,
        array $headers = [],
        StreamInterface|string|null $body = null,
        string $version = '1.1',
        string|null $reason = null,
Severity: Minor
Found in src/Fapi/HttpClient/HttpResponse.php - About 35 mins to fix

    Function processVerifyOption has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function processVerifyOption(string $verify, CurlHandle $handle): void
        {
            if ((bool) $verify) {
                $caPathOrFile = CaBundle::getSystemCaRootBundlePath();
    
    
    Severity: Minor
    Found in src/Fapi/HttpClient/CurlHttpClient.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function decode(string $json, int $options = 0): mixed
        {
            if (!(bool) preg_match('##u', $json)) {
                throw new JsonException('Invalid UTF-8 sequence', 5); // workaround for PHP < 5.3.3 & PECL JSON-C
            }
    Severity: Minor
    Found in src/Fapi/HttpClient/Utils/Json.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function processOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function processOptions(RequestInterface $request): array
        {
            $options = [];
    
            if ($request->hasHeader('timeout')) {
    Severity: Minor
    Found in src/Fapi/HttpClient/GuzzleHttpClient.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language