Sign upLogin

fey/php-project-lvl2

View on GitHub
Star
src/Diff.php

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Method makeAstDiff has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeAstDiff($data1, $data2): array
{
    $makeDiff = function ($data1, $data2) use (&$makeDiff): array {
        $nodesNames = array_keys(array_merge((array)$data1, (array)$data2));
Severity: Minor
Found in src/Diff.php - About 1 hr to fix

    The function makeAstDiff() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

    function makeAstDiff($data1, $data2): array
{
    $makeDiff = function ($data1, $data2) use (&$makeDiff): array {
        $nodesNames = array_keys(array_merge((array)$data1, (array)$data2));
    Severity: Minor
    Found in src/Diff.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The method makeAstDiff uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                        } else {
                        return makeNode([
                                'type'     => CHANGED,
                                'name'     => $nodeName,
                                'oldValue' => $data1->$nodeName,
    Severity: Minor
    Found in src/Diff.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ']'
    Open

            'plain'  => fn($diff) => formatPlain($diff),
    Severity: Critical
    Found in src/Diff.php by phan

    There are no issues that match your filters.

    Category
    Status