fga-eps-mds/2020.1-VC_Gestor-BackEnd

View on GitHub

Showing 15 of 15 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

async deleteNewsById(request, response) {
 
try {
const deletedNews = await DeleteNewsResolve(request);
Severity: Major
Found in packages/news/src/controller/NewsController.js and 1 other location - About 2 hrs to fix
packages/benefits/src/controller/BenefitController.js on lines 75..84

Similar blocks of code found in 2 locations. Consider refactoring.
Open

async deleteBenefitById(request, response) {
try {
const benefit = await DeleteBenefitResolve(request);
 
return response.json(benefit);
Severity: Major
Found in packages/benefits/src/controller/BenefitController.js and 1 other location - About 2 hrs to fix
packages/news/src/controller/NewsController.js on lines 69..78

Similar blocks of code found in 7 locations. Consider refactoring.
Open

async createBenefit(request, response) {
 
try {
const benefit = await CreateBenefitResolve(request);
 
 
Severity: Major
Found in packages/benefits/src/controller/BenefitController.js and 6 other locations - About 1 hr to fix
packages/news/src/controller/NewsController.js on lines 10..20
packages/news/src/controller/NewsController.js on lines 31..41
packages/news/src/controller/NewsController.js on lines 44..54
packages/user/src/controller/AuthenticateUserService.js on lines 6..14
packages/user/src/controller/UserController.js on lines 10..18
packages/user/src/controller/UserController.js on lines 53..60

Similar blocks of code found in 7 locations. Consider refactoring.
Open

async getByToken(request, response) {
 
try {
const user = await GetUserByTokenResolve(request);
return response.json(user);
Severity: Major
Found in packages/user/src/controller/UserController.js and 6 other locations - About 1 hr to fix
packages/benefits/src/controller/BenefitController.js on lines 17..27
packages/news/src/controller/NewsController.js on lines 10..20
packages/news/src/controller/NewsController.js on lines 31..41
packages/news/src/controller/NewsController.js on lines 44..54
packages/user/src/controller/AuthenticateUserService.js on lines 6..14
packages/user/src/controller/UserController.js on lines 53..60

Similar blocks of code found in 7 locations. Consider refactoring.
Open

async sendEmail(request, response) {
try {
const info = await SendEmailResolve(request);
return response.json(info);
} catch (err) {
Severity: Major
Found in packages/user/src/controller/UserController.js and 6 other locations - About 1 hr to fix
packages/benefits/src/controller/BenefitController.js on lines 17..27
packages/news/src/controller/NewsController.js on lines 10..20
packages/news/src/controller/NewsController.js on lines 31..41
packages/news/src/controller/NewsController.js on lines 44..54
packages/user/src/controller/AuthenticateUserService.js on lines 6..14
packages/user/src/controller/UserController.js on lines 10..18

Similar blocks of code found in 7 locations. Consider refactoring.
Open

async authenticate(request, response) {
try {
const authToken = await AuthResolve(request);
 
return response.json(authToken);
Severity: Major
Found in packages/user/src/controller/AuthenticateUserService.js and 6 other locations - About 1 hr to fix
packages/benefits/src/controller/BenefitController.js on lines 17..27
packages/news/src/controller/NewsController.js on lines 10..20
packages/news/src/controller/NewsController.js on lines 31..41
packages/news/src/controller/NewsController.js on lines 44..54
packages/user/src/controller/UserController.js on lines 10..18
packages/user/src/controller/UserController.js on lines 53..60

Similar blocks of code found in 7 locations. Consider refactoring.
Open

async putNewsById(request, response) {
 
try {
const updateNews = await UpdateNewsResolve(request);
 
 
Severity: Major
Found in packages/news/src/controller/NewsController.js and 6 other locations - About 1 hr to fix
packages/benefits/src/controller/BenefitController.js on lines 17..27
packages/news/src/controller/NewsController.js on lines 10..20
packages/news/src/controller/NewsController.js on lines 31..41
packages/user/src/controller/AuthenticateUserService.js on lines 6..14
packages/user/src/controller/UserController.js on lines 10..18
packages/user/src/controller/UserController.js on lines 53..60

Similar blocks of code found in 7 locations. Consider refactoring.
Open

async getNewsById(request, response){
try {
const getOneNews = await FindByIdResolve(request);
 
return response.json(getOneNews);
Severity: Major
Found in packages/news/src/controller/NewsController.js and 6 other locations - About 1 hr to fix
packages/benefits/src/controller/BenefitController.js on lines 17..27
packages/news/src/controller/NewsController.js on lines 10..20
packages/news/src/controller/NewsController.js on lines 44..54
packages/user/src/controller/AuthenticateUserService.js on lines 6..14
packages/user/src/controller/UserController.js on lines 10..18
packages/user/src/controller/UserController.js on lines 53..60

Similar blocks of code found in 7 locations. Consider refactoring.
Open

async create(request, response) {
 
try {
const createdNews = await CreateResolve(request);
 
 
Severity: Major
Found in packages/news/src/controller/NewsController.js and 6 other locations - About 1 hr to fix
packages/benefits/src/controller/BenefitController.js on lines 17..27
packages/news/src/controller/NewsController.js on lines 31..41
packages/news/src/controller/NewsController.js on lines 44..54
packages/user/src/controller/AuthenticateUserService.js on lines 6..14
packages/user/src/controller/UserController.js on lines 10..18
packages/user/src/controller/UserController.js on lines 53..60

Consider simplifying this complex logical expression.
Open

if (title === "" || description === "" || redeem_way === "" ||
title === null || description === null || redeem_way === null || quantity === null ) {
throw { error: "Fill request.body correctly, cannot be an empty string or null value "};
}
Severity: Major
Found in packages/benefits/src/controller/UpdateBenefitResolve.js - About 1 hr to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    module.exports = {
    dialect: "postgres",
    host: "172.25.0.2",
    username: "developer",
    password: "developer",
    Severity: Minor
    Found in packages/news/src/config/database.js and 2 other locations - About 40 mins to fix
    packages/benefits/src/config/database.js on lines 1..10
    packages/user/src/config/database.js on lines 1..10

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    module.exports = {
    dialect: "postgres",
    host: "172.25.0.2",
    username: "developer",
    password: "developer",
    Severity: Minor
    Found in packages/user/src/config/database.js and 2 other locations - About 40 mins to fix
    packages/benefits/src/config/database.js on lines 1..10
    packages/news/src/config/database.js on lines 1..10

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    module.exports = {
    dialect: "postgres",
    host: "172.25.0.2",
    username: "developer",
    password: "developer",
    Severity: Minor
    Found in packages/benefits/src/config/database.js and 2 other locations - About 40 mins to fix
    packages/news/src/config/database.js on lines 1..10
    packages/user/src/config/database.js on lines 1..10

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    const { title, subtitle, text, image1, image2, image3, post_id } = request.body;
    Severity: Minor
    Found in packages/news/src/controller/UpdateNewsResolve.js and 1 other location - About 35 mins to fix
    packages/news/src/controller/CreateResolve.js on lines 6..6

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    const { title, subtitle, text, image1, image2, image3, post_id } = request.body;
    Severity: Minor
    Found in packages/news/src/controller/CreateResolve.js and 1 other location - About 35 mins to fix
    packages/news/src/controller/UpdateNewsResolve.js on lines 6..6
    Severity
    Category
    Status
    Source
    Language