fga-eps-mds/2020.1-VC_Gestor-BackEnd

const Benefit = require("../models/benefit");
 
module.exports = {
 
  async UpdateBenefitResolve(request) {
    const { benefit_id } = request.params;
    const { title, description, redeem_way, quantity } = request.body;
 
    var benefit = await Benefit.findOne({ where: {benefit_id}});
 
    if (!benefit){
      throw { error: "Benefit not found!" };
    }
 
Consider simplifying this complex logical expression.
    if (title === "" || description === "" || redeem_way === "" ||
        title === null || description === null || redeem_way === null || quantity === null ) {
      throw { error: "Fill request.body correctly, cannot be an empty string or null value "};
    }
 
    await Benefit.update({
      benefit_id,
      title,
      description,
      redeem_way,
      quantity
    }, {
      where: {
        benefit_id
      }
    });
 
    benefit = await Benefit.findOne({ where: {benefit_id}});
 
    return benefit;
  }
};