Sign upLogin

finally-a-fast/faftephp

View on GitHub
Star

Showing 149 of 149 total issues

Method elementSettings has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function elementSettings(): array
    {
        return [
            new ElementSetting([
                'name' => 'loop-each',
Severity: Minor
Found in src/Elements/Loop.php - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Faf\TemplateEngine\Elements;
    Severity: Major
    Found in src/Elements/HtmlspecialcharsDecode.php and 3 other locations - About 1 hr to fix
    src/Elements/HtmlEntityDecode.php on lines 1..61
    src/Elements/Htmlentities.php on lines 1..61
    src/Elements/Htmlspecialchars.php on lines 1..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Faf\TemplateEngine\Elements;
    Severity: Major
    Found in src/Elements/HtmlEntityDecode.php and 3 other locations - About 1 hr to fix
    src/Elements/Htmlentities.php on lines 1..61
    src/Elements/Htmlspecialchars.php on lines 1..61
    src/Elements/HtmlspecialcharsDecode.php on lines 1..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Faf\TemplateEngine\Elements;
    Severity: Major
    Found in src/Elements/Htmlspecialchars.php and 3 other locations - About 1 hr to fix
    src/Elements/HtmlEntityDecode.php on lines 1..61
    src/Elements/Htmlentities.php on lines 1..61
    src/Elements/HtmlspecialcharsDecode.php on lines 1..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Faf\TemplateEngine\Elements;
    Severity: Major
    Found in src/Elements/Htmlentities.php and 3 other locations - About 1 hr to fix
    src/Elements/HtmlEntityDecode.php on lines 1..61
    src/Elements/Htmlspecialchars.php on lines 1..61
    src/Elements/HtmlspecialcharsDecode.php on lines 1..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method loadAllowedChildElements has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function loadAllowedChildElements(): array
    {
        $debugId = $this->debugStart('Load allowed child elements');
        $key = 'fafte-allowed-child-elements-' . md5(implode('', array_keys($this->parserElements)));
        $allowedChildElements = null;
    Severity: Minor
    Found in src/Parser.php - About 1 hr to fix

      Method getValue has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function &getValue(&$data, string $path, bool $callLastClosure = true)
    {
        static::checkForClosure($data);

        $workData = $data;
      Severity: Minor
      Found in src/Parser.php - About 1 hr to fix

        Avoid excessively long variable names like $parserElementsByClassName. Keep variable name length under 20.
        Open

            protected array $parserElementsByClassName;
        Severity: Minor
        Found in src/Parser.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $multipleAttributeExpression. Keep variable name length under 20.
        Open

            public function setMultipleAttributeExpression(string $multipleAttributeExpression): self
        Severity: Minor
        Found in src/Helpers/ElementSetting.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $multipleAttributeExpression. Keep variable name length under 20.
        Open

                            $multipleAttributeExpression = strtr($elementSetting->multipleAttributeExpression, [
        Severity: Minor
        Found in src/Parser.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $allowedChildElementsByTag. Keep variable name length under 20.
        Open

                $allowedChildElementsByTag = array_merge_recursive(
        Severity: Minor
        Found in src/Parser.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $multipleAttributeExpression. Keep variable name length under 20.
        Open

            public string $multipleAttributeExpression = '/^{{name}}(-(.*))?$/i';
        Severity: Minor
        Found in src/Helpers/ElementSetting.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $allowedChildElementsByType. Keep variable name length under 20.
        Open

                $allowedChildElementsByType = array_merge_recursive(
        Severity: Minor
        Found in src/Parser.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Function getRawValue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function &getRawValue($value)
    {
        if (is_array($value) || is_object($value)) {
            return $value;
        }
        Severity: Minor
        Found in src/Parser.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run(): string
    {
        //TODO default settings from parser
        //'machine_time_default_format', 'yyyy-MM-dd HH:mm:ss';
        //'human_time_default_format', 'medium';
        Severity: Minor
        Found in src/Elements/TimeTag.php - About 1 hr to fix

          The class Parser has 26 fields. Consider redesigning Parser to keep the number of fields under 15.
          Open

          class Parser extends BaseObject
{
    public const ROOT = 'root';

    public const MODE_PROD = 0;
          Severity: Minor
          Found in src/Parser.php by phpmd

          TooManyFields

          Since: 0.1

          Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

          Example

          class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

          Source https://phpmd.org/rules/codesize.html#toomanyfields

          Method htmlTag has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function htmlTag(
        string $name,
        string $content = '',
        ?array $options = [],
        string $attributePrefix = ''
          Severity: Minor
          Found in src/Parser.php - About 1 hr to fix

            Method elementSettings has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function elementSettings(): array
    {
        return [
            new ElementSetting([
                'name' => 'string',
            Severity: Minor
            Found in src/Elements/FormatAsDate.php - About 1 hr to fix

              Function formatParams has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function formatParams(array $rawParams, bool $setAttributeData, Parser $parser): array
    {
        $params = [];

        foreach ($rawParams as $name => $value) {
              Severity: Minor
              Found in src/Helpers/DataHelper.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getRawValue has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function &getRawValue($value)
    {
        if (is_array($value) || is_object($value)) {
            return $value;
        }
              Severity: Minor
              Found in src/Parser.php - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language