Sign upLogin

finally-a-fast/faftephp

View on GitHub
Star

Showing 149 of 149 total issues

Method refresh has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function refresh(): void
    {
        if ($this->mode === self::MODE_DEV) {
            $this->debugStartTime = microtime(true);
        }
Severity: Minor
Found in src/Parser.php - About 1 hr to fix

    Method elementSettings has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function elementSettings(): array
    {
        return [
            new ElementSetting([
                'name' => 'string',
    Severity: Minor
    Found in src/Elements/FormatAsDatetime.php - About 1 hr to fix

      Method dateTimeFormatter has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function dateTimeFormatter(int $type, $dateTime, $format, $inputTimeZone = null, $timeZone = null)
    {
        if ($inputTimeZone === null) {
            $inputTimeZone = new DateTimeZone(date_default_timezone_get());
        }
      Severity: Minor
      Found in src/Parser.php - About 1 hr to fix

        Method elementSettings has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function elementSettings(): array
    {
        return [
            new ElementSetting([
                'name' => 'string',
        Severity: Minor
        Found in src/Elements/FormatAsTime.php - About 1 hr to fix

          Method run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function run(): string
    {
        /**
         * @var string $loopEach
         */
          Severity: Minor
          Found in src/Elements/Loop.php - About 1 hr to fix

            Method elementSettings has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function elementSettings(): array
    {
        return [
            new ElementSetting([
                'name' => 'value',
            Severity: Minor
            Found in src/Elements/FormatAsShortSize.php - About 1 hr to fix

              Function checkConditionArray has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function checkConditionArray(string $type, array $conditions): bool
    {
        $result = false;

        foreach ($conditions as $condition) {
              Severity: Minor
              Found in src/Elements/ConditionalStatement.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function dateTimeFormatter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function dateTimeFormatter(int $type, $dateTime, $format, $inputTimeZone = null, $timeZone = null)
    {
        if ($inputTimeZone === null) {
            $inputTimeZone = new DateTimeZone(date_default_timezone_get());
        }
              Severity: Minor
              Found in src/Parser.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function checkConditionArray has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function checkConditionArray(string $type, array $conditions): bool
    {
        $result = false;

        foreach ($conditions as $condition) {
              Severity: Minor
              Found in src/Helpers/ConditionTrait.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method handleLoopItem has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      ?int $wrapStep,
        int $numericIndex,
        string $body,
        int $itemCount,
        string $wrapTag,
              Severity: Major
              Found in src/Elements/Loop.php - About 50 mins to fix

                Avoid variables with short names like $df. Configured minimum length is 3.
                Open

                        $df = new IntlDateFormatter($this->currentLanguage, $dateType, $timeType, $timeZone, $calendar, $intlFormat);
                Severity: Minor
                Found in src/Parser.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                Method formatNumber has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        $number,
        int $style,
        string $pattern = '',
        array $attributes = [],
        array $symbols = [],
                Severity: Minor
                Found in src/Parser.php - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php

declare(strict_types=1);

namespace Faf\TemplateEngine\Elements;
                  Severity: Minor
                  Found in src/Elements/ConditionalStatementConditionOr.php and 1 other location - About 40 mins to fix
                  src/Elements/ConditionalStatementConditionAnd.php on lines 1..62

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 94.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php

declare(strict_types=1);

namespace Faf\TemplateEngine\Elements;
                  Severity: Minor
                  Found in src/Elements/ConditionalStatementConditionAnd.php and 1 other location - About 40 mins to fix
                  src/Elements/ConditionalStatementConditionOr.php on lines 1..62

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 94.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  The class Parser has a coupling between objects value of 22. Consider to reduce the number of dependencies under 13.
                  Open

                  class Parser extends BaseObject
{
    public const ROOT = 'root';

    public const MODE_PROD = 0;
                  Severity: Minor
                  Found in src/Parser.php by phpmd

                  CouplingBetweenObjects

                  Since: 1.1.0

                  A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                  Example

                  class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

                  Source https://phpmd.org/rules/design.html#couplingbetweenobjects

                  Method dateTimeFormatter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected function dateTimeFormatter(int $type, $dateTime, $format, $inputTimeZone = null, $timeZone = null)
                  Severity: Minor
                  Found in src/Parser.php - About 35 mins to fix

                    Method setLoopItemData has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            string $loopEach,
        string $loopAs,
        $currentIndex,
        int $numericIndex,
        $loopItem
                    Severity: Minor
                    Found in src/Elements/Loop.php - About 35 mins to fix

                      Function refresh has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function refresh(): void
    {
        if ($this->mode === self::MODE_DEV) {
            $this->debugStartTime = microtime(true);
        }
                      Severity: Minor
                      Found in src/Parser.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                              return $value;
                      Severity: Major
                      Found in src/Parser.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return $value;
                        Severity: Major
                        Found in src/Parser.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language