Method config
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def config(save_to, script = nil, **options)
return unless @on_config
save_to_mapper = PathMapper.new(save_to)
script = options.delete(:source) || save_to_mapper.name if script.nil?
script = script.to_s.end_with?('.erb') ? script : "#{script}.erb"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid parameter lists longer than 5 parameters. [6/5] Open
def initialize(on_reconfig:, on_config:, lib:, etc:, docker_api:, **kwargs)
- Read upRead up
- Exclude checks
This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.
Method on_reconfig
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def on_reconfig(cmd, **kwargs)
return unless @on_config
in_option = kwargs[:in]
cmd = if in_option
container_name = case in_option
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Pass __FILE__
and __LINE__
to eval
method, as they are used by backtraces. Open
self.class.class_eval("attr_accessor :#{k}")
- Read upRead up
- Exclude checks
This cop checks eval
method usage. eval
can receive source location
metadata, that are filename and line number. The metadata is used by
backtraces. This cop recommends to pass the metadata to eval
method.
Example:
# bad
eval <<-RUBY
def do_something
end
RUBY
# bad
C.class_eval <<-RUBY
def do_something
end
RUBY
# good
eval <<-RUBY, binding, __FILE__, __LINE__ + 1
def do_something
end
RUBY
# good
C.class_eval <<-RUBY, __FILE__, __LINE__ + 1
def do_something
end
RUBY
Line is too long. [167/150] Open
raise NetStatus::Exception, error: :error, code: :on_reconfig_not_supported_option_value, data: { value: in_option, option: 'in' }
- Exclude checks