Sign upLogin

fog/fog

View on GitHub
Star

Showing 460 of 460 total issues

Method [] has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def [](service)
      @@connections ||= Hash.new do |hash, key|
        hash[key] = case key
        when :auto_scale
          Fog::Rackspace::AutoScale.new
Severity: Minor
Found in lib/fog/bin/rackspace.rb - About 1 hr to fix

    Method generate_configure_vm_request has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def generate_configure_vm_request(vm_data)
          xmlns = 'http://schemas.dmtf.org/ovf/envelope/1'
          xmlns_vcloud = 'http://www.vmware.com/vcloud/v1'
          xmlns_rasd = 'http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_ResourceAllocationSettingData'
          xmlns_vssd = 'http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_VirtualSystemSettingData'
    Severity: Minor
    Found in lib/fog/vcloud/requests/compute/configure_vm.rb - About 1 hr to fix

      Method get_org_vdc_gateways has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def get_org_vdc_gateways(vdc_id)
          unless data[:vdcs][vdc_id]
            raise Fog::Compute::VcloudDirector::Forbidden.new(
              "No access to entity \"(com.vmware.vcloud.entity.vdc:#{vdc_id})\"."
            )
      Severity: Minor
      Found in lib/fog/vcloud_director/requests/compute/get_org_vdc_gateways.rb - About 1 hr to fix

        Method vm_allocate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def vm_allocate(attr={ })

          if(attr[:flavor].nil?)
            raise(ArgumentError.new("Attribute flavor is nil! #{attr.inspect}"))
          end
        Severity: Minor
        Found in lib/fog/opennebula/requests/compute/vm_allocate.rb - About 1 hr to fix

          Method get_network_complete has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def get_network_complete(id)
          unless network = data[:networks][id]
            raise Fog::Compute::VcloudDirector::Forbidden.new(
              'This operation is denied.'
            )
          Severity: Minor
          Found in lib/fog/vcloud_director/requests/compute/get_network_complete.rb - About 1 hr to fix

            Method post_upload_disk has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def post_upload_disk(id, name, size, options={})
          unless size.to_s =~ /^\d+$/
            raise Fog::Compute::VcloudDirector::BadRequest.new(
              "validation error on field 'diskSpec.sizeBytes': must be greater than or equal to 0"
            )
            Severity: Minor
            Found in lib/fog/vcloud_director/requests/compute/post_upload_disk.rb - About 1 hr to fix

              Method get_organizations_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_organizations_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_organizations_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_catalogs_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_catalogs_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_catalogs_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_users_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_users_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_users_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_groups_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_groups_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_groups_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method list_addresses has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def list_addresses
          # Loop through addresses and update states and values if they aren't set
          self.data[:addresses].values.each do |address|
            address['state']    = 2 if address['state'] == 0
            address['ip']       = Fog::IBM::Mock.ip_address if address['ip'].empty?
              Severity: Minor
              Found in lib/fog/ibm/requests/compute/list_addresses.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_disks_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_disks_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_disks_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_medias_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_medias_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_medias_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_vapp_templates_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_vapp_templates_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_vapp_templates_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method list_groups has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def list_groups(filter={})
          groups = []
          net1 = mock_group "1", 'net1'
          net2 = mock_group "2", 'fogtest'
              Severity: Minor
              Found in lib/fog/opennebula/requests/compute/list_groups.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_vapps_in_lease_from_query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_vapps_in_lease_from_query(options={})
          query = []
          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
          query << "page=#{options[:page]}" if options[:page]
              Severity: Minor
              Found in lib/fog/vcloud_director/requests/compute/get_vapps_in_lease_from_query.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                module Compute
    class CloudSigma
      class Real
        def clone_snapshot(snap_id, clone_params={})
          request(:path => "snapshots/#{snap_id}/action/",
              Severity: Major
              Found in lib/fog/cloudsigma/requests/clone_snapshot.rb and 3 other locations - About 1 hr to fix
              lib/fog/cloudsigma/requests/clone_libvolume.rb on lines 2..26
              lib/fog/cloudsigma/requests/clone_server.rb on lines 2..26
              lib/fog/cloudsigma/requests/clone_volume.rb on lines 2..26

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                module Compute
    class CloudSigma
      class Real
        def clone_libvolume(vol_id, clone_params={})
          request(:path => "libdrives/#{vol_id}/action/",
              Severity: Major
              Found in lib/fog/cloudsigma/requests/clone_libvolume.rb and 3 other locations - About 1 hr to fix
              lib/fog/cloudsigma/requests/clone_server.rb on lines 2..26
              lib/fog/cloudsigma/requests/clone_snapshot.rb on lines 2..26
              lib/fog/cloudsigma/requests/clone_volume.rb on lines 2..26

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method list_groups has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def list_groups(filter = {})

          groups=[]
          grouppool = ::OpenNebula::GroupPool.new(client)
          grouppool.info
              Severity: Minor
              Found in lib/fog/opennebula/requests/compute/list_groups.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                module Compute
    class CloudSigma
      class Real
        def clone_volume(vol_id, clone_params={})
          request(:path => "drives/#{vol_id}/action/",
              Severity: Major
              Found in lib/fog/cloudsigma/requests/clone_volume.rb and 3 other locations - About 1 hr to fix
              lib/fog/cloudsigma/requests/clone_libvolume.rb on lines 2..26
              lib/fog/cloudsigma/requests/clone_server.rb on lines 2..26
              lib/fog/cloudsigma/requests/clone_snapshot.rb on lines 2..26

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language