fossasia/loklak_webclient

View on GitHub

Showing 915 of 915 total issues

File html-utils.js has 421 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function() {

    var $ = require('cheerio');
    var _ = require('underscore');

Severity: Minor
Found in iframely/lib/html-utils.js - About 6 hrs to fix

    Function xhr has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

        xhr: function(method, url, headers, data, callback) {
    
            var r = new XMLHttpRequest();
            var error = this.error;
    
    
    Severity: Minor
    Found in app/js/components/hello.all.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function append has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

        append: function(node, attr, target) {
    
            var n = typeof (node) === 'string' ? document.createElement(node) : node;
    
            if (typeof (attr) === 'object') {
    Severity: Minor
    Found in app/js/components/hello.all.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  var result = {
                    'previousView': 'day',
                    'currentView': 'hour',
                    'nextView': configuration.minView === 'hour' ? 'setTime' : 'minute',
                    'previousViewDate': new DateObject({
    Severity: Major
    Found in app/js/components/datetimepicker.js and 1 other location - About 6 hrs to fix
    app/js/components/datetimepicker.js on lines 206..217

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  var result = {
                    'previousView': 'year',
                    'currentView': 'month',
                    'nextView': configuration.minView === 'month' ? 'setTime' : 'day',
                    'previousViewDate': new DateObject({
    Severity: Major
    Found in app/js/components/datetimepicker.js and 1 other location - About 6 hrs to fix
    app/js/components/datetimepicker.js on lines 288..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function postTweet has 150 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $rootScope.root.postTweet = function() {
    
            var message = $rootScope.root.tweet;
            var tweetLen = twttr.txt.getTweetLength(message);
            var tweet = encodeURIComponent(message);
    Severity: Major
    Found in app/js/controllers/tweet.js - About 6 hrs to fix

      Function postTweet has 150 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                   $rootScope.root.postTweet = function() {
      
                       var message = $rootScope.root.tweet;
                       var tweetLen = twttr.txt.getTweetLength(message);
                       var tweet = encodeURIComponent(message);
      Severity: Major
      Found in app/js/directives/tweet-feature-drt.js - About 6 hrs to fix

        Function exports has 150 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            module.exports = function(app){
        
                app.get('/tests/run/:plugin', function(req, res, next) {
        
                    if (req.params.plugin == "all") {
        Severity: Major
        Found in iframely/modules/tests-ui/views.js - About 6 hrs to fix

          Function googleChartDirective has 149 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function googleChartDirective($timeout, $window, $rootScope, googleChartApiPromise) {
          
                  GoogleChartController.$inject = ['$scope', '$element', '$attrs', '$injector', 'FormatManager'];
          
                  function GoogleChartController($scope, $element, $attrs, $injector, FormatManager){
          Severity: Major
          Found in app/js/components/ng-google-chart.js - About 5 hrs to fix

            File wallDisplay.js has 412 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            'use strict';
            /* global angular */
            /* jshint unused:false */
            
            var controllersModule = require('./_index');
            Severity: Minor
            Found in app/js/controllers/wallDisplay.js - About 5 hrs to fix

              Function run has 146 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  var run = core.run = function(uri, options, cb) {
              
                      if (typeof options === 'function') {
                          cb = options;
                          options = {};
              Severity: Major
              Found in iframely/lib/core.js - About 5 hrs to fix

                Function api has 145 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                hello.api = function() {
                
                    // Shorthand
                    var _this = this;
                    var utils = _this.utils;
                Severity: Major
                Found in app/js/components/hello.all.js - About 5 hrs to fix

                  Function mapLayoutDirective has 142 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function mapLayoutDirective(MapPopUpTemplateService, $interval, $location, MapCreationService) {
                  
                      return {
                          scope: {
                              data: '=',
                  Severity: Major
                  Found in app/js/directives/mapLayout.js - About 5 hrs to fix

                    Consider simplifying this complex logical expression.
                    Open

                        if (meta) {
                            var isJetpack = meta.twitter && meta.twitter.card === 'jetpack';
                            var isWordpress = meta.generator && /wordpress/i.test(meta.generator);
                    
                            var isShopify = false;
                    Severity: Critical
                    Found in iframely/lib/utils.js - About 5 hrs to fix

                      Function GoogleChartController has 141 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              function GoogleChartController($scope, $element, $attrs, $injector, FormatManager){
                                  var self = this;
                                  var resizeHandler, wrapperListeners = {}, formatManager,
                                      chartListeners = {}, innerVisualization = null;
                                  self.registerChartListener = registerChartListener;
                      Severity: Major
                      Found in app/js/components/ng-google-chart.js - About 5 hrs to fix

                        Function $get has 139 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              function($interval, $log, $rootScope, $document, Keepalive, LocalStorage, $window) {
                                var state = {
                                  idle: null,
                                  timeout: null,
                                  idling: false,
                        Severity: Major
                        Found in app/js/components/angular-idle.js - About 5 hrs to fix

                          Function login has 138 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              login: function() {
                          
                                  // Create an object which inherits its parent as the prototype and constructs a new event chain.
                                  var _this = this;
                                  var utils = _this.utils;
                          Severity: Major
                          Found in app/js/components/hello.all.js - About 5 hrs to fix

                            Function SearchService has 138 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function SearchService($q, $http, $rootScope, AppSettings) {
                            
                              var service = {};
                            
                              $rootScope.root.numberOfFailedReq = 0;
                            Severity: Major
                            Found in app/js/services/search.js - About 5 hrs to fix

                              Function Event has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  Event: function() {
                              
                                      var separator = /[\s\,]+/;
                              
                                      // If this doesn't support getPrototype then we can't get prototype.events of the parent
                              Severity: Minor
                              Found in app/js/components/hello.all.js - About 5 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function getOembed has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
                              Open

                              exports.getOembed = function(uri, data, options) {
                              
                                  if (!data) {
                                      return;
                                  }
                              Severity: Minor
                              Found in iframely/lib/oembed.js - About 5 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language