Sign upLogin

fremag/MemoScope.Net

View on GitHub
Star

Showing 125 of 126 total issues

File ClrDump.cs has 504 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System.Collections.Generic;
using System.Linq;
using MemoScope.Core.Dac;
using Microsoft.Diagnostics.Runtime;
using System;
Severity: Major
Found in MemoScope/Core/ClrDump.cs - About 1 day to fix

    Method SetUpAddressColumn has a Cognitive Complexity of 59 (exceeds 20 allowed). Consider refactoring.
    Open

            public static void SetUpAddressColumn(this ObjectListView listView, OLVColumn col, UIClrDumpModule dumpModule, string suffix = null)
        {
            col.AspectToStringFormat = "{0:X}";
            col.TextAlign = HorizontalAlignment.Right;
            col.Width = 150;
    Severity: Minor
    Found in MemoScope/Core/Helpers/ObjectListViewHelpers.cs - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ObjectListViewHelpers.cs has 422 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using BrightIdeasSoftware;
using MemoScope.Core.Data;
using MemoScope.Modules.InstanceDetails;
using MemoScope.Tools.RegexFilter;
using Microsoft.Diagnostics.Runtime;
    Severity: Minor
    Found in MemoScope/Core/Helpers/ObjectListViewHelpers.cs - About 6 hrs to fix

      Class ClrDump has 44 methods (exceeds 20 allowed). Consider refactoring.
      Open

          public class ClrDump : IClrDump
    {
        static Logger logger = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType.FullName);

        private static int n = 0;
      Severity: Minor
      Found in MemoScope/Core/ClrDump.cs - About 6 hrs to fix

        Method SetUpAddressColumn has 131 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public static void SetUpAddressColumn(this ObjectListView listView, OLVColumn col, UIClrDumpModule dumpModule, string suffix = null)
        {
            col.AspectToStringFormat = "{0:X}";
            col.TextAlign = HorizontalAlignment.Right;
            col.Width = 150;
        Severity: Major
        Found in MemoScope/Core/Helpers/ObjectListViewHelpers.cs - About 5 hrs to fix

          File ClrDumpCache.cs has 357 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          using Microsoft.Diagnostics.Runtime;
using System.Collections.Generic;
using System.Data.SQLite;
using System.IO;
using WinFwk.UITools.Log;
          Severity: Minor
          Found in MemoScope/Core/Cache/ClrDumpCache.cs - About 4 hrs to fix

            File ProcessModule.cs has 349 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            using ExpressionEvaluator;
using MemoScope.Core.ProcessInfo;
using MemoScope.Modules.Explorer;
using MemoScope.Tools.CodeTriggers;
using MemoScopeApi;
            Severity: Minor
            Found in MemoScope/Modules/Process/ProcessModule.cs - About 4 hrs to fix

              Method Analyze has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
              Open

                      public static List<ArrayInstanceInformation> Analyze(ArraysAddressList arrayAddressList, MessageBus msgBus)
        {
            var clrDump = arrayAddressList.ClrDump;
            var clrType = arrayAddressList.ClrType;
            var typeName = clrType.Name;
              Severity: Minor
              Found in MemoScope/Modules/ArrayInstances/ArrayInstanceAnalysis.cs - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File InstancesModule.cs has 312 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              using BrightIdeasSoftware;
using MemoScope.Core.Data;
using MemoScope.Core.Helpers;
using Microsoft.Diagnostics.Runtime;
using System.Collections.Generic;
              Severity: Minor
              Found in MemoScope/Modules/Instances/InstancesModule.cs - About 3 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                using MemoScope.Core.Data;
using System;
using System.Windows.Forms;
using WinFwk.UICommands;
using WinFwk.UIModules;
                Severity: Major
                Found in MemoScope/Modules/Delegates/Targets/DelegateTargetsCommand.cs and 1 other location - About 3 hrs to fix
                MemoScope/Modules/Delegates/Instances/DelegateInstancesCommand.cs on lines 1..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 220.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                using MemoScope.Core.Data;
using System;
using System.Windows.Forms;
using WinFwk.UICommands;
using WinFwk.UIModules;
                Severity: Major
                Found in MemoScope/Modules/Delegates/Instances/DelegateInstancesCommand.cs and 1 other location - About 3 hrs to fix
                MemoScope/Modules/Delegates/Targets/DelegateTargetsCommand.cs on lines 1..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 220.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public List<BlockingObject> GetBlockingObjects()
        {
            List<BlockingObject> blockingObjects = new List<BlockingObject>();
            CancellationTokenSource source = new CancellationTokenSource();
            var token = source.Token;
                Severity: Major
                Found in MemoScope/Core/ClrDump.cs and 1 other location - About 3 hrs to fix
                MemoScope/Core/ClrDump.cs on lines 488..518

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 219.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public List<ClrRoot> GetClrRoots()
        {
            List<ClrRoot> clrRoots = new List<ClrRoot>();
            CancellationTokenSource source = new CancellationTokenSource();
            var token = source.Token;
                Severity: Major
                Found in MemoScope/Core/ClrDump.cs and 1 other location - About 3 hrs to fix
                MemoScope/Core/ClrDump.cs on lines 456..486

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 219.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method Dump has 78 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        public void Dump()
        {
            if (proc == null)
            {
                Log("Can't dump: no process selected !", LogLevelType.Error);
                Severity: Major
                Found in MemoScope/Modules/Process/ProcessModule.cs - About 3 hrs to fix

                  Class ClrDumpCache has 24 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                      public class ClrDumpCache
    {
        ClrDump ClrDump { get; }
        public bool DataExists { get; private set; }
                  Severity: Minor
                  Found in MemoScope/Core/Cache/ClrDumpCache.cs - About 2 hrs to fix

                    Method AnalyzeReferers has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            public static List<ReferersInformation> AnalyzeReferers(MessageBus msgBus, ClrDump clrDump, HashSet<ulong> addresses)
        {
            var referers = new List<ReferersInformation>();
            var dicoByRefererType = new Dictionary<ClrType, Dictionary<string, ReferersInformation>>();
            CancellationTokenSource token = new CancellationTokenSource();
                    Severity: Major
                    Found in MemoScope/Modules/Referers/ReferersAnalysis.cs - About 2 hrs to fix

                      Method SetUpTypeColumn has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              public static void SetUpTypeColumn(this ObjectListView listView, OLVColumn col, UIClrDumpModule dumpModule=null, string suffix = null)
        {
            listView.FormatCell += (sender, e) =>
            {
                if (e.Column == col)
                      Severity: Major
                      Found in MemoScope/Core/Helpers/ObjectListViewHelpers.cs - About 2 hrs to fix

                        Method Analyze has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                public static List<ArrayInstanceInformation> Analyze(ArraysAddressList arrayAddressList, MessageBus msgBus)
        {
            var clrDump = arrayAddressList.ClrDump;
            var clrType = arrayAddressList.ClrType;
            var typeName = clrType.Name;
                        Severity: Major
                        Found in MemoScope/Modules/ArrayInstances/ArrayInstanceAnalysis.cs - About 2 hrs to fix

                          Method ManageAlias has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  public static string ManageAlias(string typeName, List<TypeAlias> typeAliases)
        {
            if( typeName == null)
            {
                return null;
                          Severity: Major
                          Found in MemoScope/Core/Helpers/TypeHelpers.cs - About 2 hrs to fix

                            Class ProcessModule has 22 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                                public partial class ProcessModule : UIModule,
        IMessageListener<DumpRequest>,
        IMessageListener<UISettingsChangedMessage>
    {
        public static readonly MemoScopeServer DumpServer;
                            Severity: Minor
                            Found in MemoScope/Modules/Process/ProcessModule.cs - About 2 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language