Sign upLogin

fsaar/TicTacToe

View on GitHub
Star
TicTacToe/TicTacToe/TTTBackendClient.swift

Summary

Maintainability
A
3 hrs
Test Coverage

Function merge has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func merge(highscores : [[String : Any]]) {
        let fetchRequest = NSFetchRequest<TTTHighscore>(entityName:String(describing:TTTHighscore.self))
        let context = TTTCoreDataStack.sharedDataStack.privateQueueManagedObjectContext
        defer {
            context.perform {
Severity: Minor
Found in TicTacToe/TicTacToe/TTTBackendClient.swift - About 1 hr to fix

    Function merge has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        func merge(highscores : [[String : Any]]) {
        let fetchRequest = NSFetchRequest<TTTHighscore>(entityName:String(describing:TTTHighscore.self))
        let context = TTTCoreDataStack.sharedDataStack.privateQueueManagedObjectContext
        defer {
            context.perform {
    Severity: Minor
    Found in TicTacToe/TicTacToe/TTTBackendClient.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function postHigscore has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        func postHigscore(with name : String,moves : Int, time : Float,callBack onQueue: OperationQueue = .main,using completionBlock: ((_ error : Error?) -> ())? = nil) {
    Severity: Minor
    Found in TicTacToe/TicTacToe/TTTBackendClient.swift - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status