Showing 140 of 140 total issues
Method ProcessVideo.startDownloadVideo
has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring. Open
func (p *ProcessVideo) startDownloadVideo() {
logger := p.getLogger()
dirpath := p.LiveStatus.Video.UsersConfig.DownloadDir
func() {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function arrangeTask
has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring. Open
func arrangeTask() {
log.Printf("Arrange tasks...")
pm := initPluginManager()
status := make([]map[string]bool, len(config.Config.Module))
for i, module := range config.Config.Module {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method ProcessVideo.startDownloadVideo
has 75 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (p *ProcessVideo) startDownloadVideo() {
logger := p.getLogger()
dirpath := p.LiveStatus.Video.UsersConfig.DownloadDir
func() {
Function arrangeTask
has 61 lines of code (exceeds 50 allowed). Consider refactoring. Open
func arrangeTask() {
log.Printf("Arrange tasks...")
pm := initPluginManager()
status := make([]map[string]bool, len(config.Config.Module))
for i, module := range config.Config.Module {
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (p *PluginManager) OnDownloadStart(video *ProcessVideo) {
var wg sync.WaitGroup
wg.Add(len(p.plugins))
for _, plug := range p.plugins {
go func(callback PluginCallback) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 154.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (p *PluginManager) OnLiveStart(video *ProcessVideo) {
var wg sync.WaitGroup
wg.Add(len(p.plugins))
for _, plug := range p.plugins {
go func(callback PluginCallback) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 154.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function HttpDoWithBufferEx
has 56 lines of code (exceeds 50 allowed). Consider refactoring. Open
func HttpDoWithBufferEx(ctx context.Context, client *http.Client, meth string, url string, header map[string]string, data []byte, buf *bytes.Buffer) (*bytes.Buffer, error) {
if client == nil {
client = &http.Client{}
}
var dataReader io.Reader
Function HttpDoWithBufferEx
has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring. Open
func HttpDoWithBufferEx(ctx context.Context, client *http.Client, meth string, url string, header map[string]string, data []byte, buf *bytes.Buffer) (*bytes.Buffer, error) {
if client == nil {
client = &http.Client{}
}
var dataReader io.Reader
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method BilibiliPoller.getStatusUseFollow
has 51 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (b *BilibiliPoller) getStatusUseFollow() error {
ctx := base.GetCtx("Bilibili")
if ctx == nil {
return nil
}
Function HttpDoWithBufferEx
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
func HttpDoWithBufferEx(ctx context.Context, client *http.Client, meth string, url string, header map[string]string, data []byte, buf *bytes.Buffer) (*bytes.Buffer, error) {
Function HttpDoWithBufferEx
has 7 return statements (exceeds 4 allowed). Open
func HttpDoWithBufferEx(ctx context.Context, client *http.Client, meth string, url string, header map[string]string, data []byte, buf *bytes.Buffer) (*bytes.Buffer, error) {
if client == nil {
client = &http.Client{}
}
var dataReader io.Reader
Method Youtube.getVideoInfo
has 5 return statements (exceeds 4 allowed). Open
func (y *Youtube) getVideoInfo(ctx *base.MonitorCtx, baseHost string, channelId string) error {
url := baseHost + "/channel/" + channelId + "/live"
htmlBody, err := ctx.HttpGet(url, map[string]string{})
if err != nil {
return err
Method BilibiliPoller.getStatusUseFollow
has 5 return statements (exceeds 4 allowed). Open
func (b *BilibiliPoller) getStatusUseFollow() error {
ctx := base.GetCtx("Bilibili")
if ctx == nil {
return nil
}
var infoJson should be infoJSON Open
infoJson, _ := simplejson.NewJson(rawInfoJSON)
- Exclude checks
var infoJson should be infoJSON Open
infoJson, _ := simplejson.NewJson(rawInfoJSON)
- Exclude checks
comment on exported function GetCleanVideoInfo should be of the form "GetCleanVideoInfo ..." Open
// sanitize everything in the videoinfo for downloader & plugins
- Exclude checks
should not use dot imports Open
. "github.com/fzxiao233/Vtb_Record/utils"
- Exclude checks
method parameter channelId should be channelID Open
func (y *Youtube) getVideoInfo(ctx *base.MonitorCtx, baseHost string, channelId string) error {
- Exclude checks
exported type CQMsg should have comment or be unexported Open
type CQMsg struct {
- Exclude checks
exported method DownloaderStreamlink.StartDownload should have comment or be unexported Open
func (d *DownloaderStreamlink) StartDownload(video *interfaces.VideoInfo, proxy string, cookie string, filepath string) error {
- Exclude checks