gboudreau/Greyhole

View on GitHub

Showing 334 of 371 total issues

File DBSpool.php has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
Copyright 2009-2020 Guillaume Boudreau

This file is part of Greyhole.
Severity: Minor
Found in includes/DBSpool.php - About 5 hrs to fix

    Method change_config has 133 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function change_config($name, $value, $log_fct, &$error = NULL) {
            if (empty($log_fct)) {
                $log_fct = function($log) { error_log($log); };
            }
    
    
    Severity: Major
    Found in includes/CLI/ConfigCliRunner.php - About 5 hrs to fix

      Function trash_file has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function trash_file($real_path, $file_was_modified = FALSE) {
              $is_symlink = FALSE;
              clearstatcache();
              if (is_link($real_path)) {
                  $is_symlink = TRUE;
      Severity: Minor
      Found in includes/Trash.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function samba_restart has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function samba_restart() {
              Log::info("The Samba daemon will now restart...");
              if (is_file('/etc/init/smbd.conf')) {
                  exec("/sbin/restart smbd");
              } else if (is_file('/etc/init.d/samba')) {
      Severity: Minor
      Found in includes/SambaUtils.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File functions.inc.php has 374 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      /*
      Copyright 2020 Guillaume Boudreau
      
      This file is part of Greyhole.
      Severity: Minor
      Found in web-app/functions.inc.php - About 5 hrs to fix

        Method init has 123 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function init() {
                Log::setLevel(Config::get(CONFIG_LOG_LEVEL));
        
                self::$df_command = "df -k";
                foreach (Config::storagePoolDrives() as $sp_drive) {
        Severity: Major
        Found in includes/ConfigHelper.php - About 4 hrs to fix

          Function get_free_space has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function get_free_space($for_sp_drive) {
                  if (time() > StoragePool::$last_df_time + Config::get(CONFIG_DF_CACHE_TIME)) {
                      $dfs = [];
                      exec(ConfigHelper::$df_command, $responses);
                      $responses_arr = array();
          Severity: Minor
          Found in includes/StoragePool.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function convertStoragePoolDrivesTagFiles has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function convertStoragePoolDrivesTagFiles() {
                  global $going_drive;
          
                  $drives_definitions = Settings::get('sp_drives_definitions', TRUE);
                  if (!$drives_definitions) {
          Severity: Minor
          Found in includes/MigrationHelper.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method execute has 122 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function execute() {
                  $share = $this->share;
                  $full_path = $this->full_path;
                  $task_id = $this->id;
          
          
          Severity: Major
          Found in includes/Tasks/WriteTask.php - About 4 hrs to fix

            Method balance_file has 119 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function balance_file($file, $share, $share_options, $source_drive, &$pool_drives_avail_space, $balance_direction_asc, &$file_too_large_warnings) {
                    $num_total_drives = count($pool_drives_avail_space);
                    $current_avail_space = $pool_drives_avail_space[$source_drive];
                    $target_avail_space = array_sum($pool_drives_avail_space) / count($pool_drives_avail_space);
                    $delta_needed = $target_avail_space - $current_avail_space;
            Severity: Major
            Found in includes/Tasks/BalanceTask.php - About 4 hrs to fix

              Function directory_uuid has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function directory_uuid($dir) {
                      $dev = exec('df ' . escapeshellarg($dir) . ' 2> /dev/null | grep \'/dev\' | awk \'{print $1}\'');
                      if (!is_dir($dir)) {
                          return FALSE;
                      }
              Severity: Minor
              Found in includes/SystemHelper.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              DB has 36 functions (exceeds 20 allowed). Consider refactoring.
              Open

              final class DB {
              
                  /** @var stdClass */
                  protected static $options; // connection options
                  /** @var PDO */
              Severity: Minor
              Found in includes/DB.php - About 4 hrs to fix

                Method check_drives has 116 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function check_drives() {
                        Log::setAction(ACTION_CHECK_POOL);
                
                        // If last 'df' ran less than 10s ago, all the drives are already awake; no harm checking them at this time.
                        global $last_df_time;
                Severity: Major
                Found in includes/StoragePool.php - About 4 hrs to fix

                  Function samba_check_vfs has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function samba_check_vfs() {
                          $vfs_is_ok = FALSE;
                  
                          // Samba version
                          $version = str_replace('.', '', SambaUtils::samba_get_version());
                  Severity: Minor
                  Found in includes/SambaUtils.php - About 4 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function json_pretty_print has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function json_pretty_print($json) {
                      if (defined('JSON_PRETTY_PRINT')) {
                          if (is_string($json)) {
                              $json = json_decode($json);
                          }
                  Severity: Minor
                  Found in includes/common.php - About 4 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create_metafiles has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function create_metafiles($share, $full_path, $num_copies_required, $filesize, $metafiles=[]) {
                          $found_link_metafile = FALSE;
                  
                          list($path, ) = explode_full_path($full_path);
                  
                  
                  Severity: Minor
                  Found in includes/Metastores.php - About 4 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method create_file_copies_from_metafiles has 107 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function create_file_copies_from_metafiles($metafiles, $share, $full_path, $source_file, $missing_only = FALSE) {
                          $landing_zone = get_share_landing_zone($share);
                  
                          list($path, $filename) = explode_full_path($full_path);
                  
                  
                  Severity: Major
                  Found in includes/StorageFile.php - About 4 hrs to fix

                    Function execute has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function execute() {
                            $this->drive = $this->full_path;
                    
                            // Removing this drive here will insure it won't be used for new files while we're moving files away, and that it can later be replaced.
                            StoragePool::remove_drive($this->drive);
                    Severity: Minor
                    Found in includes/Tasks/RemoveTask.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function get_file_copies_inodes has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function get_file_copies_inodes($share, $file_path, $filename, &$file_metafiles, $one_is_enough = FALSE) {
                            $file_copies_inodes = [];
                    
                            foreach (Config::storagePoolDrives() as $sp_drive) {
                                $clean_full_path = clean_dir("$sp_drive/$share/$file_path/$filename");
                    Severity: Minor
                    Found in includes/StoragePool.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method execute_next_task has 103 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function execute_next_task() {
                            if (!empty($this->next_tasks)) {
                                $task = array_shift($this->next_tasks);
                            } else {
                                $this->next_tasks = $this->fetch_next_tasks(TRUE, TRUE);
                    Severity: Major
                    Found in includes/DBSpool.php - About 4 hrs to fix
                      Severity
                      Category
                      Status
                      Source
                      Language