Sign upLogin

gdbots/pbjx-php

View on GitHub
Star

Showing 107 of 107 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function updateNormalizers(Index $index, string $name): void
    {
        $settings = $index->getSettings();
        $customNormalizers = $this->getCustomNormalizers();
        $missingNormalizers = [];
Severity: Major
Found in src/EventSearch/Elastica/IndexManager.php and 1 other location - About 1 day to fix
src/EventSearch/Elastica/IndexManager.php on lines 246..301

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 314.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function updateAnalyzers(Index $index, string $name): void
    {
        $settings = $index->getSettings();
        $customAnalyzers = $this->getCustomAnalyzers();
        $missingAnalyzers = [];
Severity: Major
Found in src/EventSearch/Elastica/IndexManager.php and 1 other location - About 1 day to fix
src/EventSearch/Elastica/IndexManager.php on lines 310..365

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 314.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File DynamoDbEventStore.php has 619 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Pbjx\EventStore\DynamoDb;
Severity: Major
Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 day to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function createResponseForFailedRequest(Message $request, \Throwable $exception): Message
    {
        $code = $exception->getCode() > 0 ? $exception->getCode() : Code::UNKNOWN->value;

        $response = RequestFailedResponseV1::create()
    Severity: Major
    Found in src/SimpleRequestBus.php and 1 other location - About 7 hrs to fix
    src/Transport/AbstractTransport.php on lines 133..158

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function createResponseForFailedRequest(Message $request, \Throwable $exception): Message
    {
        $code = $exception->getCode() > 0 ? $exception->getCode() : Code::UNKNOWN->value;

        $response = RequestFailedResponseV1::create()
    Severity: Major
    Found in src/Transport/AbstractTransport.php and 1 other location - About 7 hrs to fix
    src/SimpleRequestBus.php on lines 56..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method doPipeAllEvents has 154 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function doPipeAllEvents(?Microtime $since = null, ?Microtime $until = null, array $context = []): \Generator
    {
        $tableName = $this->getTableNameForRead($context);
        $reindexing = filter_var($context['reindexing'] ?? false, FILTER_VALIDATE_BOOLEAN);
        $skipErrors = filter_var($context['skip_errors'] ?? false, FILTER_VALIDATE_BOOLEAN);
    Severity: Major
    Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 6 hrs to fix

      Method getStreamSlice has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          final public function getStreamSlice(StreamId $streamId, ?Microtime $since = null, int $count = 25, bool $forward = true, bool $consistent = false, array $context = []): StreamSlice
    {
        $context['stream_id'] = $streamId;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
      Severity: Major
      Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 3 hrs to fix

        File ElasticaEventSearch.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
declare(strict_types=1);

namespace Gdbots\Pbjx\EventSearch\Elastica;
        Severity: Minor
        Found in src/EventSearch/Elastica/ElasticaEventSearch.php - About 3 hrs to fix

          Function cancelJobs has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

              public function cancelJobs(array $jobIds, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableName($context);
          Severity: Minor
          Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function doPipeAllEvents has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function doPipeAllEvents(?Microtime $since = null, ?Microtime $until = null, array $context = []): \Generator
    {
        $tableName = $this->getTableNameForRead($context);
        $reindexing = filter_var($context['reindexing'] ?? false, FILTER_VALIDATE_BOOLEAN);
        $skipErrors = filter_var($context['skip_errors'] ?? false, FILTER_VALIDATE_BOOLEAN);
          Severity: Minor
          Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getStreamSlice has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              final public function getStreamSlice(StreamId $streamId, ?Microtime $since = null, int $count = 25, bool $forward = true, bool $consistent = false, array $context = []): StreamSlice
    {
        $context['stream_id'] = $streamId;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
          Severity: Minor
          Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  try {
            $this->client->transactWriteItems([
                // todo: implement ClientRequestToken
                'TransactItems' => $items,
            ]);
          Severity: Major
          Found in src/EventStore/DynamoDb/DynamoDbEventStore.php and 2 other locations - About 2 hrs to fix
          src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 253..278
          src/Scheduler/DynamoDb/DynamoDbScheduler.php on lines 94..158

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 136.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  try {
            $command->freeze();
            $payload = $this->marshaler->marshal($command);

            // a command will not be sent in the same context as we currently
          Severity: Major
          Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php and 2 other locations - About 2 hrs to fix
          src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 253..278
          src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 342..370

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 136.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  try {
            $response = $this->client->query($params);
        } catch (\Throwable $e) {
            if ($e instanceof AwsException) {
                $errorName = $e->getAwsErrorCode() ?: ClassUtil::getShortName($e);
          Severity: Major
          Found in src/EventStore/DynamoDb/DynamoDbEventStore.php and 2 other locations - About 2 hrs to fix
          src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 342..370
          src/Scheduler/DynamoDb/DynamoDbScheduler.php on lines 94..158

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 136.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File DynamoDbScheduler.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
declare(strict_types=1);

namespace Gdbots\Pbjx\Scheduler\DynamoDb;
          Severity: Minor
          Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 2 hrs to fix

            Method sendAt has 65 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function sendAt(Message $command, int $timestamp, ?string $jobId = null, array $context = []): string
    {
        $context['causator'] = $command;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $ttl = strtotime('+7 days', $timestamp);
            Severity: Major
            Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 2 hrs to fix

              Method startExecution has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function startExecution(
        string $stateMachineArn,
        int $timestamp,
        string $jobId,
        ?string $tenantId = null
              Severity: Major
              Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 2 hrs to fix

                Method searchEvents has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    final public function searchEvents(Message $request, ParsedQuery $parsedQuery, Message $response, array $curies = [], array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $skipValidation = filter_var($context['skip_validation'] ?? true, FILTER_VALIDATE_BOOLEAN);
        $client = $this->getClientForRead($context);
                Severity: Major
                Found in src/EventSearch/Elastica/ElasticaEventSearch.php - About 2 hrs to fix

                  Function trigger has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function trigger(Message $message, string $suffix, ?PbjxEvent $event = null, bool $recursive = true, bool $throw = true): static
    {
        $suffix = '.' . trim($suffix, '.');
        if ('.' === $suffix) {
            throw new InvalidArgumentException('Trigger requires a non-empty suffix.');
                  Severity: Minor
                  Found in src/SimplePbjx.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method run has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      final public function run(int $maxRuntime = 300): void
    {
        if ($this->isRunning) {
            $this->logger->notice(sprintf('Consumer [%s] is already running.', $this->consumerName));
            return;
                  Severity: Major
                  Found in src/Consumer/AbstractConsumer.php - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language