Sign upLogin

gdbots/pbjx-php

View on GitHub
Star

Showing 107 of 107 total issues

Method putEvents has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    final public function putEvents(StreamId $streamId, array $events, ?string $expectedEtag = null, array $context = []): void
    {
        if (!count($events)) {
            // ignore empty events array
            return;
Severity: Major
Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

    Method indexEvents has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        final public function indexEvents(array $events, array $context = []): void
    {
        if (empty($events)) {
            return;
        }
    Severity: Major
    Found in src/EventSearch/Elastica/ElasticaEventSearch.php - About 2 hrs to fix

      Method getEvent has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          final public function getEvent(Identifier $eventId, array $context = []): Message
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
        $key = $this->getItemKeyByEventId($eventId, $context);
      Severity: Major
      Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

        Method create has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function create(DynamoDbClient $client, string $tableName): void
    {
        try {
            $client->describeTable(['TableName' => $tableName]);
            return;
        Severity: Minor
        Found in src/EventStore/DynamoDb/EventStoreTable.php - About 1 hr to fix

          Method getItemKeyByEventId has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getItemKeyByEventId(Identifier $eventId, array $context = []): ?array
    {
        $tableName = $this->getTableNameForRead($context);
        $params = [
            'TableName'                 => $tableName,
          Severity: Minor
          Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

            Method deleteEvents has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                final public function deleteEvents(array $eventIds, array $context = []): void
    {
        if (empty($eventIds)) {
            return;
        }
            Severity: Minor
            Found in src/EventSearch/Elastica/ElasticaEventSearch.php - About 1 hr to fix

              Method updateAnalyzers has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function updateAnalyzers(Index $index, string $name): void
    {
        $settings = $index->getSettings();
        $customAnalyzers = $this->getCustomAnalyzers();
        $missingAnalyzers = [];
              Severity: Minor
              Found in src/EventSearch/Elastica/IndexManager.php - About 1 hr to fix

                Method updateNormalizers has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function updateNormalizers(Index $index, string $name): void
    {
        $settings = $index->getSettings();
        $customNormalizers = $this->getCustomNormalizers();
        $missingNormalizers = [];
                Severity: Minor
                Found in src/EventSearch/Elastica/IndexManager.php - About 1 hr to fix

                  Function getStreamSlice has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getStreamSlice(StreamId $streamId, ?Microtime $since = null, int $count = 25, bool $forward = true, bool $consistent = false, array $context = []): StreamSlice
    {
        $key = $streamId->toString();
        if (!isset($this->streams[$key])) {
            return new StreamSlice([], $streamId, $forward, $consistent, false);
                  Severity: Minor
                  Found in src/EventStore/InMemoryEventStore.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function sendCommand(Message $command): void
    {
        $transportEvent = new TransportEvent($this->transportName, $command);
        $this->dispatcher->dispatch($transportEvent, PbjxEvents::TRANSPORT_BEFORE_SEND);
                  Severity: Major
                  Found in src/Transport/AbstractTransport.php and 1 other location - About 1 hr to fix
                  src/Transport/AbstractTransport.php on lines 61..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 115.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function sendEvent(Message $event): void
    {
        $transportEvent = new TransportEvent($this->transportName, $event);
        $this->dispatcher->dispatch($transportEvent, PbjxEvents::TRANSPORT_BEFORE_SEND);
                  Severity: Major
                  Found in src/Transport/AbstractTransport.php and 1 other location - About 1 hr to fix
                  src/Transport/AbstractTransport.php on lines 32..47

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 115.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method cancelJobs has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function cancelJobs(array $jobIds, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableName($context);
                  Severity: Minor
                  Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 1 hr to fix

                    Method getClient has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getClient(string $cluster = 'default'): Client
    {
        if (isset($this->clients[$cluster])) {
            return $this->clients[$cluster];
        }
                    Severity: Minor
                    Found in src/EventSearch/Elastica/ClientManager.php - About 1 hr to fix

                      Method trigger has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function trigger(Message $message, string $suffix, ?PbjxEvent $event = null, bool $recursive = true, bool $throw = true): static
    {
        $suffix = '.' . trim($suffix, '.');
        if ('.' === $suffix) {
            throw new InvalidArgumentException('Trigger requires a non-empty suffix.');
                      Severity: Minor
                      Found in src/SimplePbjx.php - About 1 hr to fix

                        Function startExecution has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function startExecution(
        string $stateMachineArn,
        int $timestamp,
        string $jobId,
        ?string $tenantId = null
                        Severity: Minor
                        Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function getEvent has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                            final public function getEvent(Identifier $eventId, array $context = []): Message
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
        $key = $this->getItemKeyByEventId($eventId, $context);
                        Severity: Minor
                        Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function putEvents has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                            final public function putEvents(StreamId $streamId, array $events, ?string $expectedEtag = null, array $context = []): void
    {
        if (!count($events)) {
            // ignore empty events array
            return;
                        Severity: Minor
                        Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function describe(DynamoDbClient $client, string $tableName): string
    {
        try {
            $result = $client->describeTable(['TableName' => $tableName]);
            return json_encode($result->toArray(), JSON_PRETTY_PRINT);
                        Severity: Major
                        Found in src/Scheduler/DynamoDb/SchedulerTable.php and 1 other location - About 1 hr to fix
                        src/EventStore/DynamoDb/EventStoreTable.php on lines 93..110

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 110.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function describe(DynamoDbClient $client, string $tableName): string
    {
        try {
            $result = $client->describeTable(['TableName' => $tableName]);
            return json_encode($result->toArray(), JSON_PRETTY_PRINT);
                        Severity: Major
                        Found in src/EventStore/DynamoDb/EventStoreTable.php and 1 other location - About 1 hr to fix
                        src/Scheduler/DynamoDb/SchedulerTable.php on lines 79..96

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 110.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function sendAt has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function sendAt(Message $command, int $timestamp, ?string $jobId = null, array $context = []): string
    {
        $context['causator'] = $command;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $ttl = strtotime('+7 days', $timestamp);
                        Severity: Minor
                        Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language