Sign upLogin

gdbots/pbjx-php

View on GitHub
Star
src/EventStore/DynamoDb/DynamoDbEventStore.php

Summary

Maintainability
F
6 days
Test Coverage

File DynamoDbEventStore.php has 619 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Pbjx\EventStore\DynamoDb;
Severity: Major
Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 day to fix

    Method doPipeAllEvents has 154 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function doPipeAllEvents(?Microtime $since = null, ?Microtime $until = null, array $context = []): \Generator
    {
        $tableName = $this->getTableNameForRead($context);
        $reindexing = filter_var($context['reindexing'] ?? false, FILTER_VALIDATE_BOOLEAN);
        $skipErrors = filter_var($context['skip_errors'] ?? false, FILTER_VALIDATE_BOOLEAN);
    Severity: Major
    Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 6 hrs to fix

      Method getStreamSlice has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          final public function getStreamSlice(StreamId $streamId, ?Microtime $since = null, int $count = 25, bool $forward = true, bool $consistent = false, array $context = []): StreamSlice
    {
        $context['stream_id'] = $streamId;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
      Severity: Major
      Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 3 hrs to fix

        Function doPipeAllEvents has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function doPipeAllEvents(?Microtime $since = null, ?Microtime $until = null, array $context = []): \Generator
    {
        $tableName = $this->getTableNameForRead($context);
        $reindexing = filter_var($context['reindexing'] ?? false, FILTER_VALIDATE_BOOLEAN);
        $skipErrors = filter_var($context['skip_errors'] ?? false, FILTER_VALIDATE_BOOLEAN);
        Severity: Minor
        Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getStreamSlice has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            final public function getStreamSlice(StreamId $streamId, ?Microtime $since = null, int $count = 25, bool $forward = true, bool $consistent = false, array $context = []): StreamSlice
    {
        $context['stream_id'] = $streamId;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
        Severity: Minor
        Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method putEvents has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            final public function putEvents(StreamId $streamId, array $events, ?string $expectedEtag = null, array $context = []): void
    {
        if (!count($events)) {
            // ignore empty events array
            return;
        Severity: Major
        Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

          Method getEvent has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              final public function getEvent(Identifier $eventId, array $context = []): Message
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
        $key = $this->getItemKeyByEventId($eventId, $context);
          Severity: Major
          Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 2 hrs to fix

            Method getItemKeyByEventId has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function getItemKeyByEventId(Identifier $eventId, array $context = []): ?array
    {
        $tableName = $this->getTableNameForRead($context);
        $params = [
            'TableName'                 => $tableName,
            Severity: Minor
            Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

              Function getEvent has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  final public function getEvent(Identifier $eventId, array $context = []): Message
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForRead($context);
        $key = $this->getItemKeyByEventId($eventId, $context);
              Severity: Minor
              Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function putEvents has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  final public function putEvents(StreamId $streamId, array $events, ?string $expectedEtag = null, array $context = []): void
    {
        if (!count($events)) {
            // ignore empty events array
            return;
              Severity: Minor
              Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method deleteEvent has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  final public function deleteEvent(Identifier $eventId, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForWrite($context);
        $key = $this->getItemKeyByEventId($eventId, $context);
              Severity: Minor
              Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

                Function getItemKeyByEventId has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function getItemKeyByEventId(Identifier $eventId, array $context = []): ?array
    {
        $tableName = $this->getTableNameForRead($context);
        $params = [
            'TableName'                 => $tableName,
                Severity: Minor
                Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function deleteEvent has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    final public function deleteEvent(Identifier $eventId, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableNameForWrite($context);
        $key = $this->getItemKeyByEventId($eventId, $context);
                Severity: Minor
                Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getStreamSlice has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    final public function getStreamSlice(StreamId $streamId, ?Microtime $since = null, int $count = 25, bool $forward = true, bool $consistent = false, array $context = []): StreamSlice
                Severity: Minor
                Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 45 mins to fix

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          Pbjx $pbjx,
        DynamoDbClient $client,
        string $tableName,
        EventDispatcher $dispatcher,
        ?LoggerInterface $logger = null
                  Severity: Minor
                  Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 35 mins to fix

                    Function pipeEvents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        final public function pipeEvents(StreamId $streamId, ?Microtime $since = null, ?Microtime $until = null, array $context = []): \Generator
    {
        $context['stream_id'] = $streamId;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $consistent = filter_var($context['consistent'] ?? true, FILTER_VALIDATE_BOOLEAN);
                    Severity: Minor
                    Found in src/EventStore/DynamoDb/DynamoDbEventStore.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            try {
            $response = $this->client->query($params);
        } catch (\Throwable $e) {
            if ($e instanceof AwsException) {
                $errorName = $e->getAwsErrorCode() ?: ClassUtil::getShortName($e);
                    Severity: Major
                    Found in src/EventStore/DynamoDb/DynamoDbEventStore.php and 2 other locations - About 2 hrs to fix
                    src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 342..370
                    src/Scheduler/DynamoDb/DynamoDbScheduler.php on lines 94..158

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 136.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            try {
            $this->client->transactWriteItems([
                // todo: implement ClientRequestToken
                'TransactItems' => $items,
            ]);
                    Severity: Major
                    Found in src/EventStore/DynamoDb/DynamoDbEventStore.php and 2 other locations - About 2 hrs to fix
                    src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 253..278
                    src/Scheduler/DynamoDb/DynamoDbScheduler.php on lines 94..158

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 136.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            foreach (['s16', 's32', 's64', 's128', 's256'] as $shard) {
            if (isset($context[$shard])) {
                $params['ExpressionAttributeNames']["#{$shard}"] = $shard;
                $params['ExpressionAttributeValues'][":v_{$shard}"] = ['N' => (string)((int)$context[$shard])];
                $filterExpressions[] = "#{$shard} = :v_{$shard}";
                    Severity: Minor
                    Found in src/EventStore/DynamoDb/DynamoDbEventStore.php and 1 other location - About 50 mins to fix
                    src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 450..456

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            foreach (['s16', 's32', 's64', 's128', 's256'] as $shard) {
            if (isset($context[$shard])) {
                $params['ExpressionAttributeNames']["#{$shard}"] = $shard;
                $params['ExpressionAttributeValues'][":v_{$shard}"] = ['N' => (string)((int)$context[$shard])];
                $filterExpressions[] = "#{$shard} = :v_{$shard}";
                    Severity: Minor
                    Found in src/EventStore/DynamoDb/DynamoDbEventStore.php and 1 other location - About 50 mins to fix
                    src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 240..246

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status