Sign upLogin

gdbots/pbjx-php

View on GitHub
Star
src/Scheduler/DynamoDb/DynamoDbScheduler.php

Summary

Maintainability
D
2 days
Test Coverage

Function cancelJobs has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function cancelJobs(array $jobIds, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableName($context);
Severity: Minor
Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File DynamoDbScheduler.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\Pbjx\Scheduler\DynamoDb;
Severity: Minor
Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 2 hrs to fix

    Method sendAt has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function sendAt(Message $command, int $timestamp, ?string $jobId = null, array $context = []): string
    {
        $context['causator'] = $command;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $ttl = strtotime('+7 days', $timestamp);
    Severity: Major
    Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 2 hrs to fix

      Method startExecution has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function startExecution(
        string $stateMachineArn,
        int $timestamp,
        string $jobId,
        ?string $tenantId = null
      Severity: Major
      Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 2 hrs to fix

        Method cancelJobs has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function cancelJobs(array $jobIds, array $context = []): void
    {
        $context = $this->enrichContext(__FUNCTION__, $context);
        $tableName = $this->getTableName($context);
        Severity: Minor
        Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 1 hr to fix

          Function startExecution has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function startExecution(
        string $stateMachineArn,
        int $timestamp,
        string $jobId,
        ?string $tenantId = null
          Severity: Minor
          Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function sendAt has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function sendAt(Message $command, int $timestamp, ?string $jobId = null, array $context = []): string
    {
        $context['causator'] = $command;
        $context = $this->enrichContext(__FUNCTION__, $context);
        $ttl = strtotime('+7 days', $timestamp);
          Severity: Minor
          Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  DynamoDbClient $dynamoDbClient,
        string $tableName,
        SfnClient $sfnClient,
        string $stateMachineArn,
        EventDispatcher $dispatcher,
          Severity: Minor
          Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php - About 45 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    try {
            $command->freeze();
            $payload = $this->marshaler->marshal($command);

            // a command will not be sent in the same context as we currently
            Severity: Major
            Found in src/Scheduler/DynamoDb/DynamoDbScheduler.php and 2 other locations - About 2 hrs to fix
            src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 253..278
            src/EventStore/DynamoDb/DynamoDbEventStore.php on lines 342..370

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 136.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status