Sign upLogin

gdbots/query-parser-php

View on GitHub
Star

Showing 85 of 85 total issues

Function addTextToQuery has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addTextToQuery(string $method, Node $node, ?Field $field = null): void
    {
        if ($node instanceof Word && $node->isStopWord() && $this->ignoreStopWords) {
            return;
        }
Severity: Minor
Found in src/Builder/ElasticaQueryBuilder.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addTermToQuery has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addTermToQuery(string $method, Node $node, ?Field $field = null, bool $cacheable = false): void
    {
        if ($node instanceof Emoji && $this->ignoreEmojis) {
            return;
        }
Severity: Minor
Found in src/Builder/ElasticaQueryBuilder.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleSubquery has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private function handleSubquery(BoolOperator $queryBoolOperator)
    {
        $this->stream->nextIf(Token::T_SUBQUERY_START);
        /** @var Node[] $nodes */
        $nodes = [];
Severity: Minor
Found in src/QueryParser.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addTextToQuery has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addTextToQuery(string $method, Node $node, ?Field $field = null): void
    {
        if ($node instanceof Word && $node->isStopWord() && $this->ignoreStopWords) {
            return;
        }
Severity: Major
Found in src/Builder/ElasticaQueryBuilder.php - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    <?php
declare(strict_types=1);

namespace Gdbots\QueryParser\Node;
    Severity: Major
    Found in src/Node/NumberRange.php and 2 other locations - About 2 hrs to fix
    src/Node/DateRange.php on lines 1..31
    src/Node/WordRange.php on lines 1..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    <?php
declare(strict_types=1);

namespace Gdbots\QueryParser\Node;
    Severity: Major
    Found in src/Node/WordRange.php and 2 other locations - About 2 hrs to fix
    src/Node/DateRange.php on lines 1..31
    src/Node/NumberRange.php on lines 1..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    <?php
declare(strict_types=1);

namespace Gdbots\QueryParser\Node;
    Severity: Major
    Found in src/Node/DateRange.php and 2 other locations - About 2 hrs to fix
    src/Node/NumberRange.php on lines 1..31
    src/Node/WordRange.php on lines 1..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method handleRange has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleRange(Range $range, Field $field, bool $cacheable = false): void
    {
        $useBoost = $field->useBoost();
        $boost = $field->getBoost();
        $boolOp = $field->getBoolOperator();
    Severity: Minor
    Found in src/Builder/ElasticaQueryBuilder.php - About 2 hrs to fix

      Method addTermToQuery has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function addTermToQuery(string $method, Node $node, ?Field $field = null, bool $cacheable = false): void
    {
        if ($node instanceof Emoji && $this->ignoreEmojis) {
            return;
        }
      Severity: Minor
      Found in src/Builder/ElasticaQueryBuilder.php - About 1 hr to fix

        Function printSimpleNode has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function printSimpleNode(string $rule, Node $node, ?Field $field = null): void
    {
        if ($this->inRange()) {
            $this->printLine(sprintf('<%s>%s</%s>', $node::NODE_TYPE, $node->getValue(), $node::NODE_TYPE));
            return;
        Severity: Minor
        Found in src/Builder/XmlQueryBuilder.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method handleSubquery has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function handleSubquery(BoolOperator $queryBoolOperator)
    {
        $this->stream->nextIf(Token::T_SUBQUERY_START);
        /** @var Node[] $nodes */
        $nodes = [];
        Severity: Minor
        Found in src/QueryParser.php - About 1 hr to fix

          Function createNodes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function createNodes(
        Token $token,
        BoolOperator $boolOperator,
        ?ComparisonOperator $comparisonOperator = null
    ): array {
          Severity: Minor
          Found in src/QueryParser.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createNodes has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function createNodes(
        Token $token,
        BoolOperator $boolOperator,
        ?ComparisonOperator $comparisonOperator = null
    ): array {
          Severity: Minor
          Found in src/QueryParser.php - About 1 hr to fix

            Method printSimpleNode has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function printSimpleNode(string $rule, Node $node, ?Field $field = null): void
    {
        if ($this->inRange()) {
            $this->printLine(sprintf('<%s>%s</%s>', $node::NODE_TYPE, $node->getValue(), $node::NODE_TYPE));
            return;
            Severity: Minor
            Found in src/Builder/XmlQueryBuilder.php - About 1 hr to fix

              Method handleField has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function handleField(string $fieldName, BoolOperator $boolOperator)
    {
        $lookahead = $this->stream->getLookahead();
        if (!$lookahead instanceof Token) {
            return $this->createWord($fieldName, $boolOperator);
              Severity: Minor
              Found in src/QueryParser.php - About 1 hr to fix

                Function endSubquery has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function endSubquery(Subquery $subquery, ?Field $field = null): void
    {
        $params = $this->boolQuery->getParams();
        if (!empty($params)) {
            $this->boolQuery->setMinimumShouldMatch(1);
                Severity: Minor
                Found in src/Builder/ElasticaQueryBuilder.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Consider simplifying this complex logical expression.
                Open

                        if ($node->useFuzzy()
            || $this->supportsFullTextSearch($field->getName())
            || $node instanceof Subquery
            || $node instanceof WordRange
            || $node instanceof Phrase
                Severity: Major
                Found in src/Builder/AbstractQueryBuilder.php - About 1 hr to fix

                  Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          string $value,
        ?BoolOperator $boolOperator = null,
        bool $useBoost = false,
        float $boost = self::DEFAULT_BOOST,
        bool $useFuzzy = false,
                  Severity: Major
                  Found in src/Node/Word.php - About 50 mins to fix

                    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            string $value,
        ?BoolOperator $boolOperator = null,
        bool $useBoost = false,
        float $boost = self::DEFAULT_BOOST,
        bool $useFuzzy = false,
                    Severity: Major
                    Found in src/Node/Date.php - About 50 mins to fix

                      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              string $value,
        ?BoolOperator $boolOperator = null,
        bool $useBoost = false,
        float $boost = self::DEFAULT_BOOST,
        bool $useFuzzy = false,
                      Severity: Minor
                      Found in src/Node/Phrase.php - About 45 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language