Sign upLogin

getlackey/lackey-cms

View on GitHub
Star

Showing 527 of 527 total issues

Avoid too many return statements within this function.
Open

    return Promise.resolve(data);
Severity: Major
Found in modules/core/server/models/content/serializer.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return [].slice.call(found);
    Severity: Major
    Found in modules/core/client/js/index.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return crawl(obj[next], elems.join('.'));
      Severity: Major
      Found in modules/core/shared/dust/path.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return Promise.resolve(mime);
        Severity: Major
        Found in modules/core/server/models/media/index.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return super.create.apply(this, [data]);
          Severity: Major
          Found in modules/core/server/models/user/index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return 1;
            Severity: Major
            Found in modules/core/client/js/table.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                                      return value;
              Severity: Major
              Found in modules/core/server/models/objection/index.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                        return Promise.resolve(OCTET);
                Severity: Major
                Found in modules/core/server/models/media/index.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return Promise.resolve(data);
                  Severity: Major
                  Found in modules/core/server/models/content/serializer.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return 0;
                    Severity: Major
                    Found in modules/core/client/js/table.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return 0;
                      Severity: Major
                      Found in modules/core/client/js/table.js - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    server.route('/api/me')
                .get(policy.loggedIn, AccountController.me)
                .put(policy.loggedIn, AccountController.update);
                        Severity: Minor
                        Found in modules/users/server/routes/login.routes.js and 1 other location - About 30 mins to fix
                        modules/users/server/routes/login.routes.js on lines 53..55

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    server.route('/api/account/identity')
                .post(policy.loggedIn, AccountController.createIdentity)
                .delete(policy.loggedIn, AccountController.removeIdentity);
                        Severity: Minor
                        Found in modules/users/server/routes/login.routes.js and 1 other location - About 30 mins to fix
                        modules/users/server/routes/login.routes.js on lines 72..74

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function startRendering has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            static startRendering() {
        var render = () => {
            if (BlockEditor.activeBlock) {
                let bounds = BlockEditor.activeBlock.getAbsoluteBoundingRect();
                        Severity: Minor
                        Found in modules/cms/client/js/block-editor.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        module.exports.handler = function (promise) {
    return function (username, password, done) {
        return promise
            .then((UserClass) => {
                return UserClass.getByProvider([UserClass.USERNAME, UserClass.EMAIL], username);
                        Severity: Minor
                        Found in modules/users/server/auth/strategies/local.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function onBeforeType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        Autocomplete.prototype.onBeforeType = function (event) {

    let clean = this._text.value.replace(/\s\s+|^\s+|\s$/g, ''),
        key = event.which || event.keyCode;
                        Severity: Minor
                        Found in modules/cms/client/js/controls/autocomplete.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                              render() {
            if (this.update) {
                  this.node.addEventListener('click', this.onClick, true);
                  if (this.media && this.media.source) {
                      return this.field(this.node, this.update, this.updatePattern.replace('$1', Media.clearSource(this.media.source)));
                        Severity: Minor
                        Found in modules/cms/client/js/media.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function showForm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                                showForm: function (opts) {
            var input = this.getInput(),
                targetCheckbox = this.getAnchorTargetCheckbox(),
                buttonCheckbox = this.getAnchorButtonCheckbox();
                        Severity: Minor
                        Found in modules/cms/client/js/galleryhref.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function checkLinkFormat has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                                checkLinkFormat: function (value) {
            // Matches any alphabetical characters followed by ://
            // Matches protocol relative "//"
            // Matches common external protocols "mailto:" "tel:" "maps:"
            // Matches relative hash link, begins with "#"
                        Severity: Minor
                        Found in modules/cms/client/js/galleryhref.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function walk has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        module.exports.walk = function walk(schema) {
    if (typeof schema !== 'object') return schema;
    if (schema.type === 'paragraph' && schema.content) {
        let hasYOUTUBE = false;
        schema.content.forEach((node) => {
                        Severity: Minor
                        Found in modules/cms/shared/treeparser.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language