Sign upLogin

getsentry/raven-ruby

View on GitHub
Star

Showing 156 of 156 total issues

Method subscribe! has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
Open

          def subscribe!
            record_query_source = SUPPORT_SOURCE_LOCATION && Sentry.configuration.rails.enable_db_query_source
            query_source_threshold = Sentry.configuration.rails.db_query_source_threshold_ms

            subscribe_to_event(EVENT_NAMES) do |event_name, duration, payload|
Severity: Minor
Found in sentry-rails/lib/sentry/rails/tracing/active_record_subscriber.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

consumer.subscriptions.create('AppearanceChannel', {
  initialized() {
    this.hello = this.hello.bind(this);
    this.goodbye = this.goodbye.bind(this);
  },
Severity: Major
Found in sentry-rails/examples/rails-6.0/app/javascript/channels/appearance_channel.js and 1 other location - About 1 day to fix
sentry-rails/examples/rails-7.0/app/javascript/channels/appearance_channel.js on lines 3..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 228.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

consumer.subscriptions.create('AppearanceChannel', {
  initialized() {
    this.hello = this.hello.bind(this);
    this.goodbye = this.goodbye.bind(this);
  },
Severity: Major
Found in sentry-rails/examples/rails-7.0/app/javascript/channels/appearance_channel.js and 1 other location - About 1 day to fix
sentry-rails/examples/rails-6.0/app/javascript/channels/appearance_channel.js on lines 3..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 228.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Class Configuration has 44 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Configuration
    include CustomInspection
    include LoggingHelper
    include ArgumentCheckingHelper
Severity: Minor
Found in sentry-ruby/lib/sentry/configuration.rb - About 6 hrs to fix

    Method capture_event has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

        def capture_event(event, scope, hint = {})
      return unless configuration.sending_allowed?

      if event.is_a?(ErrorEvent) && !configuration.sample_allowed?
        transport.record_lost_event(:sample_rate, "error")
    Severity: Minor
    Found in sentry-ruby/lib/sentry/client.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send_event has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_event(event, hint = nil)
      event_type = event.is_a?(Event) ? event.type : event["type"]
      data_category = Envelope::Item.data_category(event_type)
      spans_before = event.is_a?(TransactionEvent) ? event.spans.size : 0
    Severity: Minor
    Found in sentry-ruby/lib/sentry/client.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File configuration.rb has 363 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "concurrent/utility/processor_counter"

require "sentry/utils/exception_cause_chain"
require "sentry/utils/custom_inspection"
require "sentry/utils/env_helper"
    Severity: Minor
    Found in sentry-ruby/lib/sentry/configuration.rb - About 4 hrs to fix

      Class Configuration has 34 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Configuration
    # Directories to be recognized as part of your app. e.g. if you
    # have an `engines` dir at the root of your project, you may want
    # to set this to something like /(app|config|engines|lib)/
    attr_accessor :app_dirs_pattern
      Severity: Minor
      Found in sentry-raven/lib/raven/configuration.rb - About 4 hrs to fix

        Class Scope has 33 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class Scope
    include ArgumentCheckingHelper

    ATTRIBUTES = [
      :transaction_name,
        Severity: Minor
        Found in sentry-ruby/lib/sentry/scope.rb - About 4 hrs to fix

          File configuration.rb has 338 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'uri'

module Raven
  class Configuration
    # Directories to be recognized as part of your app. e.g. if you
          Severity: Minor
          Found in sentry-raven/lib/raven/configuration.rb - About 4 hrs to fix

            Method set_initial_sample_decision has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
            Open

                def set_initial_sample_decision(sampling_context:)
      unless @tracing_enabled
        @sampled = false
        return
      end
            Severity: Minor
            Found in sentry-ruby/lib/sentry/transaction.rb - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Class Hub has 28 methods (exceeds 20 allowed). Consider refactoring.
            Open

              class Hub
    include ArgumentCheckingHelper

    attr_reader :last_event_id
            Severity: Minor
            Found in sentry-ruby/lib/sentry/hub.rb - About 3 hrs to fix

              Method format_headers_for_sentry has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                  def format_headers_for_sentry(env_hash)
      env_hash.each_with_object({}) do |(key, value), memo|
        begin
          key = key.to_s # rack env can contain symbols
          next memo['X-Request-Id'] ||= Utils::RequestId.read_from(env_hash) if Utils::RequestId::REQUEST_ID_HEADERS.include?(key)
              Severity: Minor
              Found in sentry-raven/lib/raven/integrations/rack.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File sentry-ruby.rb has 288 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require "English"
require "forwardable"
require "time"

require "sentry/version"
              Severity: Minor
              Found in sentry-ruby/lib/sentry-ruby.rb - About 2 hrs to fix

                Method to_hash has 72 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def to_hash
      unless @sampled
        record_lost_event(:sample_rate)
        return {}
      end
                Severity: Major
                Found in sentry-ruby/lib/sentry/profiler.rb - About 2 hrs to fix

                  Method to_hash has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def to_hash
      unless @sampled
        record_lost_event(:sample_rate)
        return {}
      end
                  Severity: Minor
                  Found in sentry-ruby/lib/sentry/profiler.rb - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function exports has 68 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(api) {
  var validEnv = ['development', 'test', 'production']
  var currentEnv = api.env()
  var isDevelopmentEnv = api.env('development')
  var isProductionEnv = api.env('production')
                  Severity: Major
                  Found in sentry-rails/examples/rails-6.0/babel.config.js - About 2 hrs to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                      class LineCache
    def initialize
      @cache = {}
    end
                    Severity: Major
                    Found in sentry-ruby/lib/sentry/linecache.rb and 1 other location - About 2 hrs to fix
                    sentry-raven/lib/raven/linecache.rb on lines 2..41

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 94.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                      class LineCache
    def initialize
      @cache = {}
    end
                    Severity: Major
                    Found in sentry-raven/lib/raven/linecache.rb and 1 other location - About 2 hrs to fix
                    sentry-ruby/lib/sentry/linecache.rb on lines 5..44

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 94.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method process has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def process(value)
      case value
      when Hash
        !value.frozen? ? value.merge!(value) { |_, v| process v } : value.merge(value) { |_, v| process v }
      when Array
                    Severity: Minor
                    Found in sentry-raven/lib/raven/processor/utf8conversion.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language