Sign upLogin

getsentry/raven-ruby

View on GitHub
Star
sentry-sidekiq/lib/sentry/sidekiq-scheduler/scheduler.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method new_job has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def new_job(name, interval_type, config, schedule, options)
        # Schedule the job upstream first
        # SidekiqScheduler does not validate schedules
        # It will fail with an error if the schedule in the config is invalid.
        # If this errors out, let it fall through.
Severity: Minor
Found in sentry-sidekiq/lib/sentry/sidekiq-scheduler/scheduler.rb - About 1 hr to fix

    Method new_job has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def new_job(name, interval_type, config, schedule, options)
        # Schedule the job upstream first
        # SidekiqScheduler does not validate schedules
        # It will fail with an error if the schedule in the config is invalid.
        # If this errors out, let it fall through.
    Severity: Minor
    Found in sentry-sidekiq/lib/sentry/sidekiq-scheduler/scheduler.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new_job has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def new_job(name, interval_type, config, schedule, options)
    Severity: Minor
    Found in sentry-sidekiq/lib/sentry/sidekiq-scheduler/scheduler.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status