Sign upLogin

giedomak/Telepath

View on GitHub
Star

Showing 60 of 60 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        inMap.compute(edge, { _, value -> value?.add(node2); value ?: HashSet(listOf(node2)) })
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Syn1.kt and 2 other locations - About 55 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Syn2.kt on lines 32..32
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Syn2.kt on lines 35..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    /**
     * Number of nodes in G which have incoming [edges].
     */
    fun `in`(edges: Pair<Edge, Edge>): Int {
        return syn2.inMap[edges]?.size ?: 0
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 2 other locations - About 50 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 49..56
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    /**
     * Number of pairs in G labeled by l1/l2.
     */
    fun pairs(edges: Pair<Edge, Edge>): Int {
        return syn2.pairsMap[edges]?.size ?: 0
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 2 other locations - About 50 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 42..47
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 49..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    /**
     * Number of nodes in G which have incoming edge labeled l1 and outgoing edge labeled l2.
     *
     * Where l1 is the first element of the [edges] pair, and l2 is the second element of the pair.
     */
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt and 2 other locations - About 50 mins to fix
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 42..47
src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Synopsis.kt on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                        for (operator in LogicalPlan.OPERATORS) {

                            // Actually check for containment with the operator.
                            if (logicalPlan.containsSubtreesThroughOperator(subtree1, subtree2, operator)) {
Severity: Major
Found in src/main/java/com/github/giedomak/telepath/utilities/CardinalityBenchmark.kt - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            for (operator in LogicalPlan.OPERATORS) {

                            // Actually check for containment with the operator.
                            if (logicalPlan.containsSubtreesThroughOperator(subtree1, subtree2, operator)) {
    Severity: Major
    Found in src/main/java/com/github/giedomak/telepath/planner/DynamicProgrammingPlanner.kt - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      package com.github.giedomak.telepath.costmodel

import com.github.giedomak.telepath.datamodels.plans.PhysicalPlan

/**
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/costmodel/AdvancedCostModel.kt and 1 other location - About 40 mins to fix
      src/main/java/com/github/giedomak/telepath/evaluationengine/SimpleEvaluationEngine.kt on lines 1..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      /**
 * Copyright (C) 2016-2017 - All rights reserved.
 * This file is part of the telepath project which is released under the GPLv3 license.
 * See file LICENSE.txt or go to http://www.gnu.org/licenses/gpl.txt for full license details.
 * You may use, distribute and modify this code under the terms of the GPLv3 license.
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/evaluationengine/SimpleEvaluationEngine.kt and 1 other location - About 40 mins to fix
      src/main/java/com/github/giedomak/telepath/costmodel/AdvancedCostModel.kt on lines 1..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          val middleMap = hashMapOf<Pair<Edge, Edge>, HashSet<Node>>()
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Syn2.kt and 1 other location - About 40 mins to fix
      src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Syn2.kt on lines 10..11

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      //    val outMap = hashMapOf<Pair<Edge, Edge>, HashSet<Node>>()
    val inMap = hashMapOf<Pair<Edge, Edge>, HashSet<Node>>()
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Syn2.kt and 1 other location - About 40 mins to fix
      src/main/java/com/github/giedomak/telepath/cardinalityestimation/synopsis/Syn2.kt on lines 12..12

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  val split = line.split(" ".toRegex()).dropLastWhile { it.isEmpty() }.toTypedArray()
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/kpathindex/utilities/LUBMImport.kt and 2 other locations - About 35 mins to fix
      src/main/java/com/github/giedomak/telepath/datamodels/stores/PathIdentifierStore.kt on lines 180..180
      src/main/java/com/github/giedomak/telepath/kpathindex/utilities/GMarkImport.kt on lines 45..45

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      val split = line.split(" ".toRegex()).dropLastWhile { it.isEmpty() }.toTypedArray()
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/kpathindex/utilities/GMarkImport.kt and 2 other locations - About 35 mins to fix
      src/main/java/com/github/giedomak/telepath/datamodels/stores/PathIdentifierStore.kt on lines 180..180
      src/main/java/com/github/giedomak/telepath/kpathindex/utilities/LUBMImport.kt on lines 26..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              val edgeIds = serializedEdgeSet.split(";".toRegex()).dropLastWhile { it.isEmpty() }.toTypedArray()
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/datamodels/stores/PathIdentifierStore.kt and 2 other locations - About 35 mins to fix
      src/main/java/com/github/giedomak/telepath/kpathindex/utilities/GMarkImport.kt on lines 45..45
      src/main/java/com/github/giedomak/telepath/kpathindex/utilities/LUBMImport.kt on lines 26..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (nodes[j]!!.hasChild(1))
                    print("\\")
                else
                    printWhitespaces(1)
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/datamodels/plans/utilities/MultiTreePrinter.kt and 1 other location - About 35 mins to fix
      src/main/java/com/github/giedomak/telepath/datamodels/plans/utilities/MultiTreePrinter.kt on lines 108..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (nodes[j]!!.hasChild(2))
                    print("\\")
                else
                    printWhitespaces(1)
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/datamodels/plans/utilities/MultiTreePrinter.kt and 1 other location - About 35 mins to fix
      src/main/java/com/github/giedomak/telepath/datamodels/plans/utilities/MultiTreePrinter.kt on lines 101..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (importedLines % 5000 == 0L) {
                    Logger.debug("\r Currently inserted: $importedLines", false)
                }
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/kpathindex/utilities/LUBMImport.kt and 1 other location - About 30 mins to fix
      src/main/java/com/github/giedomak/telepath/kpathindex/utilities/AdvogatoImport.kt on lines 45..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (importedLines % 5000 == 0L) {
                    Logger.debug("\r Currently inserted: $importedLines", false)
                }
      Severity: Minor
      Found in src/main/java/com/github/giedomak/telepath/kpathindex/utilities/AdvogatoImport.kt and 1 other location - About 30 mins to fix
      src/main/java/com/github/giedomak/telepath/kpathindex/utilities/LUBMImport.kt on lines 62..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this method.
      Open

              return 0
      Severity: Major
      Found in src/main/java/com/github/giedomak/telepath/datamodels/graph/Path.kt - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true
        Severity: Major
        Found in src/main/java/com/github/giedomak/telepath/datamodels/plans/AbstractMultiTree.kt - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  if (children != other.children) return false
          Severity: Major
          Found in src/main/java/com/github/giedomak/telepath/datamodels/plans/AbstractMultiTree.kt - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language