gitlabhq/gitlab-shell

View on GitHub

Showing 71 of 107 total issues

Method Command.Execute has 5 return statements (exceeds 4 allowed).
Open

func (c *Command) Execute(ctx context.Context) (context.Context, error) {
    args := c.Args.SshArgs
    if len(args) != 3 {
        return ctx, disallowedcommand.Error
    }
Severity: Major
Found in internal/command/lfstransfer/lfstransfer.go - About 35 mins to fix

    Method OSGSSAPIServer.AcceptSecContext has 5 return statements (exceeds 4 allowed).
    Open

    func (server *OSGSSAPIServer) AcceptSecContext(
        token []byte,
    ) (
        outputToken []byte,
        srcName string,
    Severity: Major
    Found in internal/sshd/gssapi.go - About 35 mins to fix

      Method Client.Unlock has 5 return statements (exceeds 4 allowed).
      Open

      func (c *Client) Unlock(id string, force bool, refname string) (*Lock, error) {
          var ref *batchRef
          if refname != "" {
              ref = &batchRef{
                  Name: refname,
      Severity: Major
      Found in internal/gitlabnet/lfstransfer/client.go - About 35 mins to fix

        Method Client.ListLocksVerify has 5 return statements (exceeds 4 allowed).
        Open

        func (c *Client) ListLocksVerify(path, id, cursor string, limit int, ref string) (*ListLocksVerifyResponse, error) {
            url, err := url.Parse(c.href)
            if err != nil {
                return nil, err
            }
        Severity: Major
        Found in internal/gitlabnet/lfstransfer/client.go - About 35 mins to fix

          Function newFromFile has 5 return statements (exceeds 4 allowed).
          Open

          func newFromFile(path string) (*Config, error) {
              cfg := &Config{}
              *cfg = DefaultConfig
              cfg.RootDir = filepath.Dir(path)
          
          
          Severity: Major
          Found in internal/config/config.go - About 35 mins to fix

            Method serverConfig.get has 5 return statements (exceeds 4 allowed).
            Open

            func (s *serverConfig) get(parentCtx context.Context) *ssh.ServerConfig {
                var gssapiWithMICConfig *ssh.GSSAPIWithMICConfig
                if s.cfg.Server.GSSAPI.Enabled {
                    gssAPIServer, _ := NewGSSAPIServer(&s.cfg.Server.GSSAPI)
            
            
            Severity: Major
            Found in internal/sshd/server_config.go - About 35 mins to fix

              Method Client.do has 5 return statements (exceeds 4 allowed).
              Open

              func (c *Client) do(request *http.Request) (*http.Response, error) {
                  for k, v := range c.Headers {
                      request.Header.Add(k, v)
                  }
              
              
              Severity: Major
              Found in internal/gitlabnet/git/client.go - About 35 mins to fix

                Method serverConfig.handleUserCertificate has 5 return statements (exceeds 4 allowed).
                Open

                func (s *serverConfig) handleUserCertificate(ctx context.Context, user string, cert *ssh.Certificate) (*ssh.Permissions, error) {
                    if os.Getenv("FF_GITLAB_SHELL_SSH_CERTIFICATES") != "1" {
                        return nil, fmt.Errorf("handleUserCertificate: feature is disabled")
                    }
                
                
                Severity: Major
                Found in internal/sshd/server_config.go - About 35 mins to fix

                  Method Command.processAPIEndpoints has 5 return statements (exceeds 4 allowed).
                  Open

                  func (c *Command) processAPIEndpoints(ctx context.Context, response *accessverifier.Response) error {
                      client, err := gitlabnet.GetClient(c.Config)
                  
                      if err != nil {
                          return err
                  Severity: Major
                  Found in internal/command/shared/customaction/customaction.go - About 35 mins to fix

                    Method Command.Execute has 5 return statements (exceeds 4 allowed).
                    Open

                    func (c *Command) Execute(ctx context.Context) (context.Context, error) {
                        args := c.Args.SshArgs
                        if len(args) < 3 {
                            return ctx, disallowedcommand.Error
                        }
                    Severity: Major
                    Found in internal/command/lfsauthenticate/lfsauthenticate.go - About 35 mins to fix

                      Function execute has 5 return statements (exceeds 4 allowed).
                      Open

                      func execute(readWriter *readwriter.ReadWriter) (int, error) {
                          executable, err := executable.New(executable.AuthorizedKeysCheck)
                          if err != nil {
                              return exitCodeFailure, fmt.Errorf("failed to determine executable, exiting")
                          }
                      Severity: Major
                      Found in cmd/gitlab-shell-authorized-keys-check/main.go - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language