gitlabhq/gitlab-shell

client/client_test.go:25:2: var-naming: var defaultHttpOpts should be defaultHTTPOpts (revive)
client/client_test.go:115:3: expected-actual: need to reverse actual and expected values (testifylint)
client/client_test.go:137:30: response body must be closed (bodyclose)
client/client_test.go:143:31: response body must be closed (bodyclose)
client/client_test.go:151:30: response body must be closed (bodyclose)
client/client_test.go:157:31: response body must be closed (bodyclose)
client/client_test.go:165:30: response body must be closed (bodyclose)
client/client_test.go:171:31: response body must be closed (bodyclose)
client/client_test.go:183:72: unused-parameter: parameter 'token' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:276:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:287:18: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:305:73: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:317:21: response body must be closed (bodyclose)
client/httpclient.go:209:22: G115: integer overflow conversion uint64 -> int64 (gosec)
client/httpsclient_test.go:63:4: expected-actual: need to reverse actual and expected values (testifylint)
client/httpsclient_test.go:106:24: response body must be closed (bodyclose)
client/httpsclient_test.go:109:5: expected-actual: need to reverse actual and expected values (testifylint)
client/testserver/gitalyserver.go:1:1: package-comments: should have a package comment (revive)
client/testserver/gitalyserver.go:21:6: exported: exported type TestGitalyServer should have comment or be unexported (revive)
client/testserver/gitalyserver.go:26:1: exported: exported method TestGitalyServer.SSHReceivePack should have comment or be unexported (revive)
client/testserver/gitalyserver.go:38:1: exported: exported method TestGitalyServer.SSHUploadPack should have comment or be unexported (revive)
client/testserver/gitalyserver.go:50:1: exported: exported method TestGitalyServer.SSHUploadPackWithSidechannel should have comment or be unexported (revive)
client/testserver/gitalyserver.go:55:18: Error return value of `conn.Close` is not checked (errcheck)
client/testserver/gitalyserver.go:70:1: exported: exported method TestGitalyServer.SSHUploadArchive should have comment or be unexported (revive)
client/testserver/gitalyserver.go:82:1: exported: exported function StartGitalyServer should have comment or be unexported (revive)
client/testserver/gitalyserver.go:131:3: go-require: require must only be used in the goroutine running the test function (testifylint)
client/testserver/testserver.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
client/testserver/testserver.go:20:6: exported: exported type TestRequestHandler should have comment or be unexported (revive)
client/testserver/testserver.go:46:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
client/testserver/testserver.go:52:17: Error return value of `server.Serve` is not checked (errcheck)
client/testserver/testserver.go:117:18: G304: Potential file inclusion via variable (gosec)
cmd/gitlab-shell-authorized-keys-check/main.go:40:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
cmd/gitlab-shell-authorized-keys-check/main.go:43:13: unnecessary conversion (unconvert)
cmd/gitlab-shell/command/command.go:74: cmd/gitlab-shell/command/command.go:74: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: When 1.21+ only Golang is support..." (godox)
cmd/gitlab-shell/main.go:1:1: package-comments: should have a package comment (revive)
cmd/gitlab-shell/main.go:42:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell/main.go:48:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell/main.go:53:23: Error return value of `logCloser.Close` is not checked (errcheck)
cmd/gitlab-shell/main.go:60:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
cmd/gitlab-shell/main.go:61:3: exitAfterDefer: os.Exit will exit, and `defer logCloser.Close()` will not run (gocritic)
internal/command/authorizedkeys/authorized_keys.go:29: internal/command/authorizedkeys/authorized_keys.go:29: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "TODO: Log this event once we have a cons..." (godox)
internal/command/command.go:1:1: package-comments: should have a package comment (revive)
internal/command/command.go:15:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/command.go:19:6: exported: exported type LogMetadata should have comment or be unexported (revive)
internal/command/command.go:26:6: exported: exported type LogData should have comment or be unexported (revive)
internal/command/command.go:32:1: exported: exported function CheckForVersionFlag should have comment or be unexported (revive)
internal/command/command.go:43:1: exported: comment on exported function Setup should be of the form "Setup ..." (revive)
internal/command/command.go:75:15: Error return value of `closer.Close` is not checked (errcheck)
internal/command/command.go:79:1: exported: exported function NewLogData should have comment or be unexported (revive)
internal/command/lfsauthenticate/lfsauthenticate.go:87:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/lfstransfer/gitlab_backend.go:40:6: exported: exported type GitlabAuthentication should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:45:6: exported: exported type GitlabBackend should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:60:1: exported: exported function NewGitlabBackend should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:104:1: exported: exported method GitlabBackend.Batch should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:215:1: exported: exported method GitlabBackend.Upload should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:224:1: exported: exported method GitlabBackend.Verify should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:229:1: exported: exported method GitlabBackend.Download should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:237:1: exported: exported method GitlabBackend.LockBackend should have comment or be unexported (revive)
internal/command/lfstransfer/lfstransfer.go:26:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/lfstransfer/lfstransfer.go:32: Function 'Execute' is too long (63 > 60) (funlen)
internal/command/lfstransfer/lfstransfer.go:52:20: context-keys-type: should not use basic type string as key in context.WithValue (revive)
internal/command/lfstransfer/lfstransfer.go:114:9: composites: gitlab.com/gitlab-org/gitlab-shell/v14/internal/command/shared/accessverifier.Command struct literal uses unkeyed fields (govet)
internal/command/lfstransfer/lfstransfer_test.go:19:2: import 'github.com/git-lfs/pktline' is not allowed from list 'test' (depguard)
internal/command/lfstransfer/lfstransfer_test.go:278:2: declaration has 3 blank identifiers (dogsled)
internal/command/lfstransfer/lfstransfer_test.go:1114:1: cognitive complexity 33 of func `setup` is high (> 20) (gocognit)
internal/command/readwriter/readwriter.go:1:1: package-comments: should have a package comment (revive)
internal/command/readwriter/readwriter.go:7:6: exported: exported type ReadWriter should have comment or be unexported (revive)
internal/command/receivepack/gitalycall_test.go:24:4: S1038: should use t.Logf(...) instead of t.Log(fmt.Sprintf(...)) (gosimple)
internal/command/receivepack/gitalycall_test.go:31:5: var-naming: struct field keyId should be keyID (revive)
internal/command/receivepack/gitalycall_test.go:98:5: expected-actual: need to reverse actual and expected values (testifylint)
internal/config/config.go:1:1: package-comments: should have a package comment (revive)
internal/config/config.go:21:2: G101: Potential hardcoded credentials (gosec)
internal/config/config.go:24:6: exported: exported type YamlDuration should have comment or be unexported (revive)
internal/config/config.go:26:6: exported: exported type GSSAPIConfig should have comment or be unexported (revive)
internal/config/config.go:33:6: exported: exported type ServerConfig should have comment or be unexported (revive)
internal/config/config.go:64:6: exported: exported type LFSConfig should have comment or be unexported (revive)
internal/config/config.go:68:6: exported: exported type PATConfig should have comment or be unexported (revive)
internal/config/config.go:73:6: exported: exported type Config should have comment or be unexported (revive)
internal/config/config.go:79:2: var-naming: struct field GitlabUrl should be GitlabURL (revive)
internal/config/config.go:131:1: exported: exported method YamlDuration.UnmarshalYAML should have comment or be unexported (revive)
internal/config/config.go:142:1: exported: exported method Config.ApplyGlobalState should have comment or be unexported (revive)
internal/config/config.go:144:12: Error return value of `os.Setenv` is not checked (errcheck)
internal/config/config.go:196:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync/atomic.Uint32 contains sync/atomic.noCopy (govet)
internal/config/config.go:199:22: G304: Potential file inclusion via variable (gosec)
internal/config/config.go:210:3: var-naming: var unescapedUrl should be unescapedURL (revive)
internal/config/config.go:256:1: receiver-naming: receiver name cfg should be consistent with previous receiver name c for Config (revive)
internal/gitlabnet/client.go:1:1: package-comments: should have a package comment (revive)
internal/gitlabnet/client.go:14:1: exported: exported function GetClient should have comment or be unexported (revive)
internal/gitlabnet/client.go:21:15: ST1005: error strings should not be capitalized (stylecheck)
internal/gitlabnet/client.go:27:1: exported: exported function ParseJSON should have comment or be unexported (revive)
internal/gitlabnet/client.go:35:1: exported: exported function ParseIP should have comment or be unexported (revive)
internal/gitlabnet/healthcheck/client_test.go:19:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
internal/gitlabnet/lfstransfer/client.go:137: internal/gitlabnet/lfstransfer/client.go:137: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
internal/sshd/server_config_test.go:5:2: SA1019: "crypto/dsa" has been deprecated since Go 1.16 because it shouldn't be used: DSA is a legacy algorithm, and modern alternatives such as Ed25519 (implemented by package crypto/ed25519) should be used instead. Keys with 1024-bit moduli (L1024N160 parameters) are cryptographically weak, while bigger keys are not widely supported. Note that FIPS 186-5 no longer approves DSA for signature generation. (staticcheck)
internal/sshd/sshd.go:268:6: func `extractDataFromContext` is unused (unused)