Sign upLogin

glitch-soc/mastodon

View on GitHub
Star
app/controllers/concerns/auth/captcha_concern.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method extend_csp_for_captcha! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def extend_csp_for_captcha!
    policy = request.content_security_policy&.clone

    return unless captcha_required? && policy.present?
Severity: Minor
Found in app/controllers/concerns/auth/captcha_concern.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_captcha! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def check_captcha!
    return true unless captcha_required?

    if verify_hcaptcha
      true
Severity: Minor
Found in app/controllers/concerns/auth/captcha_concern.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status