glitch-soc/mastodon

View on GitHub
app/javascript/flavours/glitch/components/dropdown_menu.jsx

Summary

Maintainability
F
2 wks
Test Coverage

File dropdown_menu.jsx has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import PropTypes from 'prop-types';
import { PureComponent, cloneElement, Children } from 'react';

import classNames from 'classnames';
import { withRouter } from 'react-router-dom';
Severity: Minor
Found in app/javascript/flavours/glitch/components/dropdown_menu.jsx - About 3 hrs to fix

    Function render has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render () {
        const {
          icon,
          iconComponent,
          items,
    Severity: Major
    Found in app/javascript/flavours/glitch/components/dropdown_menu.jsx - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class Dropdown extends PureComponent {
      
        static propTypes = {
          children: PropTypes.node,
          icon: PropTypes.string,
      Severity: Major
      Found in app/javascript/flavours/glitch/components/dropdown_menu.jsx and 1 other location - About 1 wk to fix
      app/javascript/mastodon/components/dropdown_menu.jsx on lines 162..341

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1375.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class DropdownMenu extends PureComponent {
      
        static propTypes = {
          items: PropTypes.array.isRequired,
          loading: PropTypes.bool,
      Severity: Major
      Found in app/javascript/flavours/glitch/components/dropdown_menu.jsx and 1 other location - About 1 wk to fix
      app/javascript/mastodon/components/dropdown_menu.jsx on lines 20..160

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1321.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status