Sign upLogin

glitch-soc/mastodon

View on GitHub
Star
app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx

Summary

Maintainability
D
1 day
Test Coverage

Function mapDispatchToProps has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

const mapDispatchToProps = (dispatch, { intl }) => ({

  onFollow (account) {
    if (account.getIn(['relationship', 'following'])) {
      dispatch(openModal({
Severity: Minor
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  onNotifyToggle (account) {
    if (account.getIn(['relationship', 'notifying'])) {
      dispatch(followAccount(account.get('id'), { notify: false }));
    } else {
      dispatch(followAccount(account.get('id'), { notify: true }));
Severity: Major
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx and 3 other locations - About 2 hrs to fix
app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 96..102
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 98..104
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 114..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  onReblogToggle (account) {
    if (account.getIn(['relationship', 'showing_reblogs'])) {
      dispatch(followAccount(account.get('id'), { reblogs: false }));
    } else {
      dispatch(followAccount(account.get('id'), { reblogs: true }));
Severity: Major
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx and 3 other locations - About 2 hrs to fix
app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 112..118
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 98..104
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 114..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const makeMapStateToProps = () => {
  const getAccount = makeGetAccount();

  const mapStateToProps = (state, { accountId }) => ({
    account: getAccount(state, accountId),
Severity: Major
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx and 1 other location - About 2 hrs to fix
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 33..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  onInteractionModal (account) {
    dispatch(openModal({
      modalType: 'INTERACTION',
      modalProps: {
        type: 'follow',
Severity: Major
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx and 1 other location - About 1 hr to fix
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 71..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 23 locations. Consider refactoring.
Open

const messages = defineMessages({
  cancelFollowRequestConfirm: { id: 'confirmations.cancel_follow_request.confirm', defaultMessage: 'Withdraw request' },
  unfollowConfirm: { id: 'confirmations.unfollow.confirm', defaultMessage: 'Unfollow' },
  blockDomainConfirm: { id: 'confirmations.domain_block.confirm', defaultMessage: 'Block entire domain' },
});
Severity: Major
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx and 22 other locations - About 1 hr to fix
app/javascript/flavours/glitch/components/poll.jsx on lines 20..33
app/javascript/flavours/glitch/features/compose/components/language_dropdown.jsx on lines 18..22
app/javascript/flavours/glitch/features/compose/containers/compose_form_container.js on lines 23..36
app/javascript/flavours/glitch/features/explore/components/card.jsx on lines 19..23
app/javascript/flavours/glitch/features/getting_started/components/announcements.jsx on lines 29..33
app/javascript/flavours/glitch/features/home_timeline/index.jsx on lines 28..32
app/javascript/flavours/glitch/features/notifications/containers/column_settings_container.js on lines 12..16
app/javascript/flavours/glitch/features/notifications/index.jsx on lines 46..50
app/javascript/flavours/glitch/features/notifications/request.jsx on lines 22..26
app/javascript/flavours/glitch/features/ui/components/bundle_modal_error.jsx on lines 10..14
app/javascript/flavours/glitch/features/ui/components/deprecated_settings_modal.jsx on lines 16..20
app/javascript/flavours/glitch/features/ui/components/media_modal.jsx on lines 25..29
app/javascript/mastodon/components/poll.jsx on lines 20..33
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 27..31
app/javascript/mastodon/features/compose/components/language_dropdown.jsx on lines 18..22
app/javascript/mastodon/features/explore/components/card.jsx on lines 19..23
app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 29..33
app/javascript/mastodon/features/home_timeline/index.jsx on lines 28..32
app/javascript/mastodon/features/notifications/containers/column_settings_container.js on lines 12..16
app/javascript/mastodon/features/notifications/request.jsx on lines 22..26
app/javascript/mastodon/features/ui/components/bundle_modal_error.jsx on lines 10..14
app/javascript/mastodon/features/ui/components/media_modal.jsx on lines 25..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  onAddToList (account) {
    dispatch(openModal({
      modalType: 'LIST_ADDER',
      modalProps: {
        accountId: account.get('id'),
Severity: Major
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx and 3 other locations - About 30 mins to fix
app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 149..156
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 142..149
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 151..158

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  onChangeLanguages (account) {
    dispatch(openModal({
      modalType: 'SUBSCRIBED_LANGUAGES',
      modalProps: {
        accountId: account.get('id'),
Severity: Major
Found in app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx and 3 other locations - About 30 mins to fix
app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 140..147
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 142..149
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 151..158

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status