glitch-soc/mastodon

View on GitHub
app/javascript/flavours/glitch/features/compose/components/federation_button.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 14 locations. Consider refactoring.
Open

const messages = defineMessages({
  change_federation_settings: { id: 'compose.change_federation', defaultMessage: 'Change federation settings' },
  local_only_label: { id: 'federation.local_only.short', defaultMessage: 'Local-only' },
  local_only_meta: { id: 'federation.local_only.long', defaultMessage: 'Prevent this post from reaching other servers' },
  federated_label: { id: 'federation.federated.short', defaultMessage: 'Federated' },
app/javascript/flavours/glitch/actions/compose.js on lines 89..95
app/javascript/flavours/glitch/components/column_header.jsx on lines 21..27
app/javascript/flavours/glitch/features/compose/components/compose_form.jsx on lines 40..46
app/javascript/flavours/glitch/features/directory/index.jsx on lines 24..30
app/javascript/flavours/glitch/features/list_timeline/index.jsx on lines 31..37
app/javascript/flavours/glitch/features/ui/components/mute_modal.jsx on lines 23..29
app/javascript/mastodon/actions/compose.js on lines 83..89
app/javascript/mastodon/components/column_header.jsx on lines 21..27
app/javascript/mastodon/components/status.jsx on lines 72..78
app/javascript/mastodon/features/compose/components/compose_form.jsx on lines 36..42
app/javascript/mastodon/features/directory/index.jsx on lines 24..30
app/javascript/mastodon/features/list_timeline/index.jsx on lines 31..37
app/javascript/mastodon/features/ui/components/mute_modal.jsx on lines 23..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    { icon: 'link', iconComponent: ShareIcon, value: 'federated', text: intl.formatMessage(messages.federated_label), meta: intl.formatMessage(messages.federated_meta) },
app/javascript/flavours/glitch/features/compose/components/content_type_button.jsx on lines 42..42
app/javascript/flavours/glitch/features/compose/components/content_type_button.jsx on lines 43..43
app/javascript/flavours/glitch/features/compose/components/content_type_button.jsx on lines 44..44
app/javascript/flavours/glitch/features/compose/components/federation_button.jsx on lines 35..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    { icon: 'link-slash', iconComponent: ShareOffIcon, value: 'local-only', text: intl.formatMessage(messages.local_only_label), meta: intl.formatMessage(messages.local_only_meta) },
app/javascript/flavours/glitch/features/compose/components/content_type_button.jsx on lines 42..42
app/javascript/flavours/glitch/features/compose/components/content_type_button.jsx on lines 43..43
app/javascript/flavours/glitch/features/compose/components/content_type_button.jsx on lines 44..44
app/javascript/flavours/glitch/features/compose/components/federation_button.jsx on lines 34..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status