glitch-soc/mastodon

View on GitHub
app/javascript/flavours/glitch/features/compose/components/language_dropdown.jsx

Summary

Maintainability
F
2 wks
Test Coverage

File language_dropdown.jsx has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import PropTypes from 'prop-types';
import { PureComponent } from 'react';

import { injectIntl, defineMessages } from 'react-intl';

    Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render () {
        const { value, intl, frequentlyUsedLanguages } = this.props;
        const { open, placement } = this.state;
        const current = preloadedLanguages.find(lang => lang[0] === value) ?? [];
    
    

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class LanguageDropdownMenu extends PureComponent {
      
        static propTypes = {
          value: PropTypes.string.isRequired,
          frequentlyUsedLanguages: PropTypes.arrayOf(PropTypes.string).isRequired,
      app/javascript/mastodon/features/compose/components/language_dropdown.jsx on lines 26..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1950.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class LanguageDropdown extends PureComponent {
      
        static propTypes = {
          value: PropTypes.string,
          frequentlyUsedLanguages: PropTypes.arrayOf(PropTypes.string),
      app/javascript/mastodon/features/compose/components/language_dropdown.jsx on lines 248..338

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 823.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 21 locations. Consider refactoring.
      Open

      const messages = defineMessages({
        changeLanguage: { id: 'compose.language.change', defaultMessage: 'Change language' },
        search: { id: 'compose.language.search', defaultMessage: 'Search languages...' },
        clear: { id: 'emoji_button.clear', defaultMessage: 'Clear' },
      });
      app/javascript/flavours/glitch/components/poll.jsx on lines 20..33
      app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 25..29
      app/javascript/flavours/glitch/features/compose/containers/compose_form_container.js on lines 23..36
      app/javascript/flavours/glitch/features/getting_started/components/announcements.jsx on lines 29..33
      app/javascript/flavours/glitch/features/home_timeline/index.jsx on lines 28..32
      app/javascript/flavours/glitch/features/notifications/containers/column_settings_container.js on lines 12..16
      app/javascript/flavours/glitch/features/notifications/index.jsx on lines 46..50
      app/javascript/flavours/glitch/features/notifications/request.jsx on lines 22..26
      app/javascript/flavours/glitch/features/ui/components/bundle_modal_error.jsx on lines 10..14
      app/javascript/flavours/glitch/features/ui/components/deprecated_settings_modal.jsx on lines 16..20
      app/javascript/flavours/glitch/features/ui/components/media_modal.jsx on lines 25..29
      app/javascript/mastodon/components/poll.jsx on lines 20..33
      app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 27..31
      app/javascript/mastodon/features/compose/components/language_dropdown.jsx on lines 18..22
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 29..33
      app/javascript/mastodon/features/home_timeline/index.jsx on lines 28..32
      app/javascript/mastodon/features/notifications/containers/column_settings_container.js on lines 12..16
      app/javascript/mastodon/features/notifications/request.jsx on lines 22..26
      app/javascript/mastodon/features/ui/components/bundle_modal_error.jsx on lines 10..14
      app/javascript/mastodon/features/ui/components/media_modal.jsx on lines 25..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status